Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use color-scheme setting instead of gtk-theme for determining GTK_THEME_VARIANT #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rolandlo opened this issue Apr 5, 2023 · 1 comment · Fixed by #49
Closed

Use color-scheme setting instead of gtk-theme for determining GTK_THEME_VARIANT #48

rolandlo opened this issue Apr 5, 2023 · 1 comment · Fixed by #49

Comments

@rolandlo
Copy link

rolandlo commented Apr 5, 2023

The current way of determining GTK_THEME_VARIANT (and based on that APPIMAGE_GTK_THEME) is to use the gtk-theme setting:

https://github.com/linuxdeploy/linuxdeploy-plugin-gtk/blob/1f054c88fd3f0d9ee46b5d5079b4a3b31d4c051e/linuxdeploy-plugin-gtk.sh#L211-212

On my (Ubuntu 22.10) system,

gsettings get org.gnome.desktop.interface gtk-theme

returns Yaru-purple, which doesn't give any indication if I use dark mode or not, whereas

gsettings get org.gnome.desktop.interface color-scheme

returns prefer-dark which is what seems relevant.

So I would suggest replacing gtk-theme by color-scheme on that line. Or why is the current version preferable?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TheTumultuousUnicornOfDarkness @rolandlo