Allow for RHEL-style /usr/lib64 paths in build filesystem #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Checking in - is there anything I can do to move this PR forward? |
|
Sorry, I was not able to take a deep look before. The diff between them: I was wondering why /usr/lib/libgdk-3.so and /usr/lib/libgdk-3.so.0.2405.32 are missing after this PR, but there are a copy of /usr/lib/libgdk-3.so (not a symlink). A deep look on shared library libprintbackend-lpr.so:
It is definitively better with this PR, because it is using shared libraries inside AppImage instead of shared libraries on my system. Good job @freakboy3742, thank you. I feel confident to merge this PR. |
TheTumultuousUnicornOfDarkness
approved these changes
Apr 1, 2023
|
No worries - thanks for the review! |
|
This breaks my build on Ubuntu 20.04, error log: Revert to the previous commit fixes the issue. |
|
@tsl0922 can you re-run with the |
You can reproduce it with this actions yaml: https://github.com/tsl0922/ImPlay/blob/main/.github/workflows/build.yml |
|
|
hmm....these changes are, indeed, assuming the specified I believe the workaround, though, of passing an absolute path to (pardon for interjecting....ive just spent a lot of time looking at this before the PR was submitted) |
|
PRs welcome, you seem to know how to fix the problem. |
CI pipelines did not shown any regression. As you said, we did not cover the case where |
474c039 merged, it should work again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building AppImages on a RHEL or RHEL-derived system (Fedora, Centos, AlmaLinux), system libraries and GTK modules are in the
/usr/lib64folder. To ensure that linuxdeploy is able to correctly delocalise those libraries and plugins, they must be installed into/usr/lib.Fixes #44