In _fix_aggregates, use annotation_select (newer) if available else a… #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-montyskew
approved these changes
Dec 22, 2017
|
There doesn't seem to be any downside to merging this patch in. Thanks @original-montyskew for the review and testimonial re: usage. New release going out in a few minutes. 👍 |
|
Also, thank you @benmehlman for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ggregate_select
As reported by OrangeDog23 ( https://github.com/OrangeDog23 ) in issue #138 ( #138 ), django-pyodbc raises an AttributeError due to the removal of aggregate_select in django 1.10.
In order to get my django application working I've patched my fork of django-pyodbc as suggested by OrangeDog23 and the solution seems to work.
Unfortunately I do not have the required knowledge of django's database internals to be able to offer real assurance that this patch is sound. But it is working for me, and I have tried to make it as backward compatible as possible. Perhaps OrangeDog23 can comment as to the wisdom of including this patch into the project.
Thanks!
Ben Mehlman