Make sure the ~PY sigil does not trigger an unused variable warning#6
Merged
jonatanklosko merged 1 commit intomainfrom Feb 23, 2025
Merged
Make sure the ~PY sigil does not trigger an unused variable warning#6jonatanklosko merged 1 commit intomainfrom
jonatanklosko merged 1 commit intomainfrom
Conversation
josevalim
reviewed
Feb 23, 2025
| @@ -290,6 +290,9 @@ defmodule Pythonx do | |||
| for name <- defined do | |||
| quote do | |||
Contributor
There was a problem hiding this comment.
After taking a look at Elixir's source, I also think we can get the same behaviour by marking it as generated:
quote generated: true do
josevalim
reviewed
Feb 23, 2025
| @@ -290,6 +290,9 @@ defmodule Pythonx do | |||
| for name <- defined do | |||
| quote do | |||
| unquote({String.to_atom(name), [], nil}) = Map.get(globals, unquote(name), nil) | |||
Contributor
There was a problem hiding this comment.
Or even:
{String.to_atom(name), [generated: true], nil}
Member
Author
There was a problem hiding this comment.
Glorious, pushed to main, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
~PYin a module body (in a script), assigning Python variables results in unused variables warning, because the sigil always assigns the corresponding Elixir variables, regardless if they are used later.