Fix segmentation fault caused by using libraries depending on pybind11#9
Merged
jonatanklosko merged 2 commits intomainfrom Feb 25, 2025
Merged
Fix segmentation fault caused by using libraries depending on pybind11#9jonatanklosko merged 2 commits intomainfrom
jonatanklosko merged 2 commits intomainfrom
Conversation
Member
Author
|
Looks like it doesn't work on Windows Python 3.10, I will keep investigating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually a bug upstream in pybind11, which is a popular library for implementing C extension modules in Python. The bug concerns the GIL, it has been reported a long time ago (pybind/pybind11#2888) and still exists. I found another viable way for us to manage the GIL, such that we don't run into that issue. More details in the code comment.
For the record, below is the code that reliably reproduced the issue for me.
script.exs
(I also removed the interpreter finalization NIF, because we don't use and it's unlikely we ever will, so it's not worth keeping it in sync).