Improve connection URL handling and add unit tests #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
src/api/utils.ts:15
- [nitpick] Consider renaming the parameter 'rtcWsUrl' to 'rtcUrl' to better reflect that its value is converted to an HTTP URL within the function.
export function createValidateUrl(rtcWsUrl: string) {
src/api/SignalClient.ts:264
- Ensure that 'params' is an instance of URLSearchParams as expected by createRtcUrl; passing a different type may result in incorrect URL construction.
const rtcUrl = createRtcUrl(url, params);
src/api/SignalClient.ts:307
- Confirm that createRtcUrl returns a URL with the appropriate WebSocket protocol (ws or wss) required for establishing a connection; any protocol alteration might lead to connection failures.
this.ws = new WebSocket(rtcUrl);
davidzhao
approved these changes
Apr 8, 2025
Merged
svajunas-budrys
pushed a commit
to svajunas-budrys/client-sdk-js
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of the findings in #1467 and extends it by extracting things into its own util module to make it testable