Thanks to visit codestin.com
Credit goes to github.com

Skip to content

React requires the class property to be called 'className' #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2024
Merged

React requires the class property to be called 'className' #1029

merged 3 commits into from
Nov 20, 2024

Conversation

@mikljohansson
Copy link
Contributor

@mikljohansson mikljohansson commented Nov 20, 2024 •
edited
Loading

Reproduce errors as

<BarVisualizer
  trackRef={{participant, publication, source: publication?.source || Track.Source.Microphone}}
  barCount={3}>
  <span>
    <span style={{backgroundColor: "black"}}/>
  </span>
</BarVisualizer>

Adding <span>'s as children like this is required to override the theming for this component

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e9d4ab6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lukasIO
lukasIO approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that!

@lukasIO lukasIO merged commit 1289a5f into livekit:main Nov 20, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasIO lukasIO lukasIO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikljohansson @CLAassistant @lukasIO