-
Notifications
You must be signed in to change notification settings - Fork 13.4k
LWG4113: Disallow has_unique_object_representations<Incomplete[]>
#118350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It seems better to let compiler frontends to handle this. |
@llvm/issue-subscribers-clang-frontend Author: Louis Dionne (ldionne)
**Link:** https://wg21.link/LWG4113
|
True, but we should add tests for it still. We're actually lacking any kind of test coverage to ensure we're rejecting incorrect type traits uses properly. |
…ete[] This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix and I think anyone who relies on this to day is in a world of hurt. Fixes llvm#118350
…ete[] (#138291) This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix, and I think anyone who relies on this today is in a world of hurt. Fixes #118350
@philnik777 I modified the builtin, I don't know if you want to add more tests on the libc++ side |
@cor3ntin yeah, I think we should keep this open until we've added tests on the libc++ side. |
…ete[] (llvm#138291) This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix, and I think anyone who relies on this today is in a world of hurt. Fixes llvm#118350
…ete[] (llvm#138291) This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix, and I think anyone who relies on this today is in a world of hurt. Fixes llvm#118350
…ete[] (llvm#138291) This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix, and I think anyone who relies on this today is in a world of hurt. Fixes llvm#118350
…ete[] (llvm#138291) This implements [LWG4113](https://cplusplus.github.io/LWG/issue411) This is technically a breaking change, but it's a fix, and I think anyone who relies on this today is in a world of hurt. Fixes llvm#118350
Link: https://wg21.link/LWG4113
The text was updated successfully, but these errors were encountered: