Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Point workflow yaml at new docker image #133359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Point workflow yaml at new docker image #133359

wants to merge 1 commit into from

Conversation

gburgessiv
Copy link
Member

WIP; docker image hasn't landed yet (see #133137), but I want to see what wins can be verified/bugs can be found outside-of-production.

@gburgessiv gburgessiv force-pushed the point-workflow-yaml-at-new-docker-image branch from 2000467 to 33650c8 Compare March 28, 2025 03:05
@gburgessiv gburgessiv force-pushed the point-workflow-yaml-at-new-docker-image branch 11 times, most recently from 3a839f2 to 76bd0a9 Compare May 2, 2025 03:00
@gburgessiv
Copy link
Member Author

gburgessiv commented May 2, 2025 •
edited
Loading

I want to see what wins can be verified/bugs can be found outside-of-production.

  • Initial pull/unpack of a docker image is regressed by about 60s on our builders. This is done once per builder at startup, so is likely neither here nor there.
  • With a new LLVM checkout baked into the image, the 'sync' step sits around 15s.
  • With a 5wk old LLVM checkout baked into the image, the 'sync' step sits around 32s.
  • Without any LLVM checkout baked into the image, the 'sync' step sits around 75s.

So this saves somewhere from 40-60 seconds per run on Linux, assuming we expect to build new images roughly monthly.

I'll test Win next, but shaving the better part of a minute of per-run init off in exchange for 60s of VM startup time sounds like a win to me. Sounds like we might be able to make this docker image part of our cloud image at some point, which should take the VM startup cost to near-0.

@gburgessiv gburgessiv force-pushed the point-workflow-yaml-at-new-docker-image branch from df7a9c8 to 830ab92 Compare May 2, 2025 15:11
@gburgessiv
.github: rely on new llvm-project checkout
2332c97 
This is now baked into the docker images to speed up
premerge cycle times.
llvm#133359 (comment)
has initial numbers on the benefits we see in practice on bots.
@gburgessiv gburgessiv force-pushed the point-workflow-yaml-at-new-docker-image branch from 830ab92 to 2332c97 Compare May 2, 2025 15:12
@gburgessiv gburgessiv mentioned this pull request May 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gburgessiv