Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[libc++][CI] Improves updating Docker image. #134497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

mordante
Copy link
Member

@mordante mordante commented Apr 5, 2025

This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.

This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
@mordante mordante requested a review from a team as a code owner April 5, 2025 13:49
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Apr 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 5, 2025

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

This makes it easier to build a new Docker image in the CI. Since the new image is not used automatically it's safe to commit these changes directly to main. Then use a PR to test the new image.


Full diff: https://github.com/llvm/llvm-project/pull/134497.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/Dockerfile (+4)
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index af8ebd4d405f2..e0591f0224102 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -44,6 +44,10 @@
 ARG BASE_IMAGE
 FROM $BASE_IMAGE AS builder-base
 
+# Changing this file causes a rebuild of the image in a GitHub action.
+# The date uses the ISO format YYYY-MM-DD.
+RUN echo "Last forced update executed on 2025-04-05."
+
 # Make sure apt-get doesn't try to prompt for stuff like our time zone, etc.
 ENV DEBIAN_FRONTEND=noninteractive
 

@mordante mordante merged commit 2b57ebb into llvm:main Apr 28, 2025
14 of 19 checks passed
@mordante mordante deleted the review/docker_improve_updating branch April 28, 2025 16:52
mordante added a commit that referenced this pull request May 4, 2025
This image was updated in #132271.
Due to issues with upstream packages, it uses #134497 instead.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This image was updated in llvm#132271.
Due to issues with upstream packages, it uses llvm#134497 instead.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This image was updated in llvm#132271.
Due to issues with upstream packages, it uses llvm#134497 instead.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
This image was updated in llvm#132271.
Due to issues with upstream packages, it uses llvm#134497 instead.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
This image was updated in llvm#132271.
Due to issues with upstream packages, it uses llvm#134497 instead.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
This makes it easier to build a new Docker image in the CI. Since the
new image is not used automatically it's safe to commit these changes
directly to main. Then use a PR to test the new image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants