[libc++] Implement P3379R0 Constrain `std::expected` equality operators #135759

yronglin · 2025-04-15T07:55:59Z

Closes #118135

This PR implement P3379R0 Constrain std::expected equality operators.

llvmbot · 2025-04-15T07:56:34Z

@llvm/pr-subscribers-libcxx

Author: None (yronglin)

Changes

This PR implement P3379R0 Constrain std::expected equality operators.

Full diff: https://github.com/llvm/llvm-project/pull/135759.diff

8 Files Affected:

(modified) libcxx/docs/Status/Cxx2cPapers.csv (+1-1)
(modified) libcxx/include/__expected/expected.h (+27-6)
(modified) libcxx/test/std/utilities/expected/expected.expected/equality/equality.T2.pass.cpp (+7-8)
(modified) libcxx/test/std/utilities/expected/expected.expected/equality/equality.other_expected.pass.cpp (+9-7)
(modified) libcxx/test/std/utilities/expected/expected.expected/equality/equality.unexpected.pass.cpp (+7-8)
(modified) libcxx/test/std/utilities/expected/expected.void/equality/equality.other_expected.pass.cpp (+8-6)
(modified) libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp (+7-8)
(modified) libcxx/test/std/utilities/expected/types.h (+13)

diff --git a/libcxx/docs/Status/Cxx2cPapers.csv b/libcxx/docs/Status/Cxx2cPapers.csv
index b40d9eb58c24e..be591c9b6a587 100644
--- a/libcxx/docs/Status/Cxx2cPapers.csv
+++ b/libcxx/docs/Status/Cxx2cPapers.csv
@@ -78,7 +78,7 @@
 "","","","","",""
 "`P3136R1 <https://wg21.link/P3136R1>`__","Retiring niebloids","2024-11 (Wrocław)","","",""
 "`P3138R5 <https://wg21.link/P3138R5>`__","``views::cache_latest``","2024-11 (Wrocław)","","",""
-"`P3379R0 <https://wg21.link/P3379R0>`__","Constrain ``std::expected`` equality operators","2024-11 (Wrocław)","","",""
+"`P3379R0 <https://wg21.link/P3379R0>`__","Constrain ``std::expected`` equality operators","2024-11 (Wrocław)","|Complete|","21",""
 "`P2862R1 <https://wg21.link/P2862R1>`__","``text_encoding::name()`` should never return null values","2024-11 (Wrocław)","","",""
 "`P2897R7 <https://wg21.link/P2897R7>`__","``aligned_accessor``: An ``mdspan`` accessor expressing pointer over-alignment","2024-11 (Wrocław)","","",""
 "`P3355R1 <https://wg21.link/P3355R1>`__","Fix ``submdspan`` for C++26","2024-11 (Wrocław)","","",""
diff --git a/libcxx/include/__expected/expected.h b/libcxx/include/__expected/expected.h
index 03bbd1623ed5c..f8af6429c05ae 100644
--- a/libcxx/include/__expected/expected.h
+++ b/libcxx/include/__expected/expected.h
@@ -10,6 +10,7 @@
 #define _LIBCPP___EXPECTED_EXPECTED_H
 
 #include <__assert>
+#include <__concepts/boolean_testable.h>
 #include <__config>
 #include <__expected/bad_expected_access.h>
 #include <__expected/unexpect.h>
@@ -1139,8 +1140,12 @@ class expected : private __expected_base<_Tp, _Err> {
 
   // [expected.object.eq], equality operators
   template <class _T2, class _E2>
-    requires(!is_void_v<_T2>)
-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const expected<_T2, _E2>& __y) {
+  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const expected<_T2, _E2>& __y)
+    requires(!is_void_v<_T2>) && requires {
+      { *__x == *__y } -> __boolean_testable;
+      { __x.error() == __y.error() } -> __boolean_testable;
+    }
+  {
     if (__x.__has_val() != __y.__has_val()) {
       return false;
     } else {
@@ -1153,12 +1158,20 @@ class expected : private __expected_base<_Tp, _Err> {
   }
 
   template <class _T2>
-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const _T2& __v) {
+  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const _T2& __v)
+    requires(!__is_std_expected<_T2>::value) && requires {
+      { *__x == __v } -> __boolean_testable;
+    }
+  {
     return __x.__has_val() && static_cast<bool>(__x.__val() == __v);
   }
 
   template <class _E2>
-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const unexpected<_E2>& __e) {
+  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const unexpected<_E2>& __e)
+    requires requires {
+      { __x.error() == __e.error() } -> __boolean_testable;
+    }
+  {
     return !__x.__has_val() && static_cast<bool>(__x.__unex() == __e.error());
   }
 };
@@ -1851,7 +1864,11 @@ class expected<_Tp, _Err> : private __expected_void_base<_Err> {
   // [expected.void.eq], equality operators
   template <class _T2, class _E2>
     requires is_void_v<_T2>
-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const expected<_T2, _E2>& __y) {
+  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const expected<_T2, _E2>& __y)
+    requires requires {
+      { __x.error() == __y.error() } -> __boolean_testable;
+    }
+  {
     if (__x.__has_val() != __y.__has_val()) {
       return false;
     } else {
@@ -1860,7 +1877,11 @@ class expected<_Tp, _Err> : private __expected_void_base<_Err> {
   }
 
   template <class _E2>
-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const unexpected<_E2>& __y) {
+  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const unexpected<_E2>& __y)
+    requires requires {
+      { __x.error() == __y.error() } -> __boolean_testable;
+    }
+  {
     return !__x.__has_val() && static_cast<bool>(__x.__unex() == __y.error());
   }
 };
diff --git a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.T2.pass.cpp b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.T2.pass.cpp
index bc8b9de97e4d2..2959834a85dd1 100644
--- a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.T2.pass.cpp
+++ b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.T2.pass.cpp
@@ -17,18 +17,17 @@
 #include <utility>
 
 #include "test_macros.h"
+#include "../../types.h"
 
-struct Data {
-  int i;
-  constexpr Data(int ii) : i(ii) {}
-
-  friend constexpr bool operator==(const Data& data, int ii) { return data.i == ii; }
-};
+// https://wg21.link/P3379R0
+static_assert(CanCompare<std::expected<int, int>, int>);
+static_assert(CanCompare<std::expected<int, int>, EqualityComparable>);
+static_assert(!CanCompare<std::expected<int, int>, NonComparable>);
 
 constexpr bool test() {
   // x.has_value()
   {
-    const std::expected<Data, int> e1(std::in_place, 5);
+    const std::expected<EqualityComparable, int> e1(std::in_place, 5);
     int i2 = 10;
     int i3 = 5;
     assert(e1 != i2);
@@ -37,7 +36,7 @@ constexpr bool test() {
 
   // !x.has_value()
   {
-    const std::expected<Data, int> e1(std::unexpect, 5);
+    const std::expected<EqualityComparable, int> e1(std::unexpect, 5);
     int i2 = 10;
     int i3 = 5;
     assert(e1 != i2);
diff --git a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.other_expected.pass.cpp b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.other_expected.pass.cpp
index 9325c6c61ad2d..e2da668728e0d 100644
--- a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.other_expected.pass.cpp
+++ b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.other_expected.pass.cpp
@@ -18,19 +18,21 @@
 #include <utility>
 
 #include "test_macros.h"
+#include "../../types.h"
 
 // Test constraint
-template <class T1, class T2>
-concept CanCompare = requires(T1 t1, T2 t2) { t1 == t2; };
-
-struct Foo{};
-static_assert(!CanCompare<Foo, Foo>);
+static_assert(!CanCompare<NonComparable, NonComparable>);
 
 static_assert(CanCompare<std::expected<int, int>, std::expected<int, int>>);
 static_assert(CanCompare<std::expected<int, int>, std::expected<short, short>>);
 
-// Note this is true because other overloads are unconstrained
-static_assert(CanCompare<std::expected<int, int>, std::expected<void, int>>);
+// https://wg21.link/P3379R0
+static_assert(!CanCompare<std::expected<int, int>, std::expected<void, int>>);
+static_assert(CanCompare<std::expected<int, int>, std::expected<int, int>>);
+static_assert(!CanCompare<std::expected<NonComparable, int>, std::expected<NonComparable, int>>);
+static_assert(!CanCompare<std::expected<int, NonComparable>, std::expected<int, NonComparable>>);
+static_assert(!CanCompare<std::expected<NonComparable, int>, std::expected<int, NonComparable>>);
+static_assert(!CanCompare<std::expected<int, NonComparable>, std::expected<NonComparable, int>>);
 
 constexpr bool test() {
   // x.has_value() && y.has_value()
diff --git a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.unexpected.pass.cpp b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.unexpected.pass.cpp
index a8c469d01be28..cd2db0efc48b1 100644
--- a/libcxx/test/std/utilities/expected/expected.expected/equality/equality.unexpected.pass.cpp
+++ b/libcxx/test/std/utilities/expected/expected.expected/equality/equality.unexpected.pass.cpp
@@ -17,18 +17,17 @@
 #include <utility>
 
 #include "test_macros.h"
+#include "../../types.h"
 
-struct Data {
-  int i;
-  constexpr Data(int ii) : i(ii) {}
-
-  friend constexpr bool operator==(const Data& data, int ii) { return data.i == ii; }
-};
+// https://wg21.link/P3379R0
+static_assert(CanCompare<std::expected<EqualityComparable, EqualityComparable>, std::unexpected<int>>);
+static_assert(CanCompare<std::expected<EqualityComparable, int>, std::unexpected<EqualityComparable>>);
+static_assert(!CanCompare<std::expected<EqualityComparable, NonComparable>, std::unexpected<int>>);
 
 constexpr bool test() {
   // x.has_value()
   {
-    const std::expected<Data, Data> e1(std::in_place, 5);
+    const std::expected<EqualityComparable, EqualityComparable> e1(std::in_place, 5);
     std::unexpected<int> un2(10);
     std::unexpected<int> un3(5);
     assert(e1 != un2);
@@ -37,7 +36,7 @@ constexpr bool test() {
 
   // !x.has_value()
   {
-    const std::expected<Data, Data> e1(std::unexpect, 5);
+    const std::expected<EqualityComparable, EqualityComparable> e1(std::unexpect, 5);
     std::unexpected<int> un2(10);
     std::unexpected<int> un3(5);
     assert(e1 != un2);
diff --git a/libcxx/test/std/utilities/expected/expected.void/equality/equality.other_expected.pass.cpp b/libcxx/test/std/utilities/expected/expected.void/equality/equality.other_expected.pass.cpp
index 8b24875586852..224cbc610e78b 100644
--- a/libcxx/test/std/utilities/expected/expected.void/equality/equality.other_expected.pass.cpp
+++ b/libcxx/test/std/utilities/expected/expected.void/equality/equality.other_expected.pass.cpp
@@ -18,10 +18,7 @@
 #include <utility>
 
 #include "test_macros.h"
-
-// Test constraint
-template <class T1, class T2>
-concept CanCompare = requires(T1 t1, T2 t2) { t1 == t2; };
+#include "../../types.h"
 
 struct Foo{};
 static_assert(!CanCompare<Foo, Foo>);
@@ -29,8 +26,13 @@ static_assert(!CanCompare<Foo, Foo>);
 static_assert(CanCompare<std::expected<void, int>, std::expected<void, int>>);
 static_assert(CanCompare<std::expected<void, int>, std::expected<void, short>>);
 
-// Note this is true because other overloads in expected<non-void> are unconstrained
-static_assert(CanCompare<std::expected<void, int>, std::expected<int, int>>);
+// https://wg21.link/P3379R0
+static_assert(!CanCompare<std::expected<void, int>, std::expected<int, int>>);
+static_assert(CanCompare<std::expected<void, int>, std::expected<void, int>>);
+static_assert(CanCompare<std::expected<void, int>, std::expected<void, int>>);
+static_assert(!CanCompare<std::expected<void, NonComparable>, std::expected<void, NonComparable>>);
+static_assert(!CanCompare<std::expected<void, int>, std::expected<void, NonComparable>>);
+static_assert(!CanCompare<std::expected<void, NonComparable>, std::expected<void, int>>);
 
 constexpr bool test() {
   // x.has_value() && y.has_value()
diff --git a/libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp b/libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp
index 4500971131b65..4d9afaf24e3a6 100644
--- a/libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp
+++ b/libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp
@@ -17,18 +17,17 @@
 #include <utility>
 
 #include "test_macros.h"
+#include "../../types.h"
 
-struct Data {
-  int i;
-  constexpr Data(int ii) : i(ii) {}
-
-  friend constexpr bool operator==(const Data& data, int ii) { return data.i == ii; }
-};
+// https://wg21.link/P3379R0
+static_assert(CanCompare<std::expected<EqualityComparable, EqualityComparable>, std::unexpected<int>>);
+static_assert(CanCompare<std::expected<EqualityComparable, int>, std::unexpected<EqualityComparable>>);
+static_assert(!CanCompare<std::expected<EqualityComparable, NonComparable>, std::unexpected<int>>);
 
 constexpr bool test() {
   // x.has_value()
   {
-    const std::expected<void, Data> e1;
+    const std::expected<void, EqualityComparable> e1;
     std::unexpected<int> un2(10);
     std::unexpected<int> un3(5);
     assert(e1 != un2);
@@ -37,7 +36,7 @@ constexpr bool test() {
 
   // !x.has_value()
   {
-    const std::expected<void, Data> e1(std::unexpect, 5);
+    const std::expected<void, EqualityComparable> e1(std::unexpect, 5);
     std::unexpected<int> un2(10);
     std::unexpected<int> un3(5);
     assert(e1 != un2);
diff --git a/libcxx/test/std/utilities/expected/types.h b/libcxx/test/std/utilities/expected/types.h
index df73ebdfe495e..11473ca3d97de 100644
--- a/libcxx/test/std/utilities/expected/types.h
+++ b/libcxx/test/std/utilities/expected/types.h
@@ -336,4 +336,17 @@ struct CheckForInvalidWrites : public CheckForInvalidWritesBase<WithPaddedExpect
   }
 };
 
+struct NonComparable {};
+
+struct EqualityComparable {
+  int i;
+  constexpr EqualityComparable(int ii) : i(ii) {}
+
+  friend constexpr bool operator==(const EqualityComparable& data, int ii) { return data.i == ii; }
+};
+
+// Test constraint
+template <class T1, class T2>
+concept CanCompare = requires(T1 t1, T2 t2) { t1 == t2; };
+
 #endif // TEST_STD_UTILITIES_EXPECTED_TYPES_H

libcxx/docs/Status/Cxx2cPapers.csv

Zingam · 2025-04-15T20:36:15Z

@yronglin A few comments:

We now use GitHub issues to track implementation: P3379R0: Constrain std::expected equality operators #118135 You can use GitHub syntax to associte PR to the issue https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
If you are interested in implementing the rest of P2944R3: Comparisons for reference_wrapper #105424 please feel to do so.
I haven't thought about it much: would it make sense to generalize and reuse the test data between the types?

yronglin · 2025-04-15T23:45:57Z

Thanks for your review!

We now use GitHub issues to track implementation: P3379R0: Constrain std::expected equality operators #118135 You can use GitHub syntax to associte PR to the issue https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Thanks for reminding me, I didn't aware the change in the process before.

If you are interested in implementing the rest of P2944R3: Comparisons for reference_wrapper #105424 please feel to do so.

Yes, I'd like to implement the rest of P2944R3.

I haven't thought about it much: would it make sense to generalize and reuse the test data between the types?

I reuse the test data between the types because it's very similar, but I have no preference. Should we revert the reuses things?

libcxx/include/__expected/expected.h

Signed-off-by: yronglin <[email protected]>

…26 feature Signed-off-by: yronglin <[email protected]>

libcxx/include/__cxx03/module.modulemap

Signed-off-by: yronglin <[email protected]>

H-G-Hristov · 2025-04-22T18:04:11Z

@yronglin Please add

Closes #118135

to the top comment in the PR to link this PR to the GitHub issue as @frederick-vs-ja suggested above.

libcxx/include/__concepts/core_convertible_to.h

Co-authored-by: A. Jiang <[email protected]>

…tible.h Signed-off-by: yronglin <[email protected]>

github-actions · 2025-04-24T14:17:47Z

✅ With the latest revision this PR passed the C/C++ code formatter.

Signed-off-by: yronglin <[email protected]>

llvm/utils/gn/secondary/libcxx/include/BUILD.gn

Signed-off-by: yronglin <[email protected]>

libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp

Signed-off-by: yronglin <[email protected]>

huixie90 · 2025-04-26T14:33:10Z

libcxx/include/__expected/expected.h

-  _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const expected& __x, const expected<_T2, _E2>& __y) {
+#  if _LIBCPP_STD_VER >= 26
+            && requires {
+                 { *__x == *__y } -> __core_convertible_to<bool>;


what is the reason why you don't use convertible_to<bool> ?

I've told the reason in #117664 (comment).

convertible_to requires both implicit and explicit convertibility, where the standard wording only requires the latter. Moreover, due to explicit object member functions and CWG2813, we can invent a class whose prvalue is implicitly convertible to bool but xvalue isn't.

Example (Godbolt link):

#include <type_traits> #include <concepts> struct X { X() = default; X(const X&) = delete; X& operator=(const X&) = delete; template<class = void> constexpr operator bool(this X) { return true; } explicit operator bool(this X) = delete; }; static_assert(!std::is_convertible_v<X, bool>); static_assert(!std::convertible_to<X, bool>); constexpr bool b = X{};

I would say it is very contrived and I would hardly believe the standard is designed to be in this form. IMO, implicit conversion should be a superset of explicit conversion. Implicitly conversion should imply explicit conversion.

Having something is implicitly convertible to, but not explicitly convertible to , is , just , a foot gun.

This similar to non-const vs const. The example above is in the same spirit of having

void f(const Foo&);
void f(Foo&) = delete;

I would say, why?

I don't think it's intended to allow such a return type. However, the core language rules "accidentally" permits such a weird return type when there's no additional constraints/static_assert's.

IMO, P3379R0 and P2944R3 (for optional, variant, and expected) should only add constraints that reflects the "mandates" in the return statements. It seems that the original intent of operators was that natural mandates in the return statements should work for these operators, and thus no additional static_assert would be necessary.

Ah, even when there's no issue with explicit conversion, the prvalue VS xvalue problem still blocks use of convertible_to. Godbolt link.

#include <type_traits> #include <concepts> struct Y { Y() = default; Y(const Y&) = delete; Y& operator=(const Y&) = delete; constexpr operator bool(this Y) { return true; } }; static_assert(!std::is_convertible_v<Y, bool>); static_assert(!std::convertible_to<Y, bool>); constexpr bool b1 = Y{}; constexpr bool b2(Y{});

libcxx/include/__expected/expected.h

Signed-off-by: yronglin <[email protected]>

…36672) Implements https://wg21.link/P2944R3 (partially): - [pairs.spec](https://eel.is/c++draft/pairs.spec) Related issues: - Related to #105424 - Related to #118135 - PR #135759 - PR #117664 Closes: [#136763](#136763) # References - https://eel.is/c++draft/concept.booleantestable - https://eel.is/c++draft/concept.equalitycomparable --------- Co-authored-by: Hristo Hristov <[email protected]> Co-authored-by: Nikolas Klauser <[email protected]>

…vm#136672) Implements https://wg21.link/P2944R3 (partially): - [pairs.spec](https://eel.is/c++draft/pairs.spec) Related issues: - Related to llvm#105424 - Related to llvm#118135 - PR llvm#135759 - PR llvm#117664 Closes: [llvm#136763](llvm#136763) # References - https://eel.is/c++draft/concept.booleantestable - https://eel.is/c++draft/concept.equalitycomparable --------- Co-authored-by: Hristo Hristov <[email protected]> Co-authored-by: Nikolas Klauser <[email protected]>

…perator (#136672) Implements https://wg21.link/P2944R3 (partially): - [pairs.spec](https://eel.is/c++draft/pairs.spec) Related issues: - Related to #105424 - Related to #118135 - PR llvm/llvm-project#135759 - PR llvm/llvm-project#117664 Closes: [#136763](llvm/llvm-project#136763) # References - https://eel.is/c++draft/concept.booleantestable - https://eel.is/c++draft/concept.equalitycomparable --------- Co-authored-by: Hristo Hristov <[email protected]> Co-authored-by: Nikolas Klauser <[email protected]>

…vm#136672) Implements https://wg21.link/P2944R3 (partially): - [pairs.spec](https://eel.is/c++draft/pairs.spec) Related issues: - Related to llvm#105424 - Related to llvm#118135 - PR llvm#135759 - PR llvm#117664 Closes: [llvm#136763](llvm#136763) # References - https://eel.is/c++draft/concept.booleantestable - https://eel.is/c++draft/concept.equalitycomparable --------- Co-authored-by: Hristo Hristov <[email protected]> Co-authored-by: Nikolas Klauser <[email protected]>

yronglin requested a review from a team as a code owner April 15, 2025 07:56

llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Apr 15, 2025

yronglin self-assigned this Apr 15, 2025

yronglin changed the title ~~[libc++] Implement P3379R0 Constrain std::expected equality operators~~ [libc++] Implement P3379R0 Constrain std::expected equality operators Apr 15, 2025

frederick-vs-ja reviewed Apr 15, 2025

View reviewed changes

libcxx/docs/Status/Cxx2cPapers.csv Show resolved Hide resolved

frederick-vs-ja reviewed Apr 16, 2025

View reviewed changes

libcxx/include/__expected/expected.h Outdated Show resolved Hide resolved

H-G-Hristov mentioned this pull request Apr 22, 2025

[libc++][pair] P2944R3: Constrain std::pair's equality operator #136672

Merged

yronglin added 2 commits April 22, 2025 22:37

[libc++] Implement P3379R0 Constrain std::expected equality operators

a8aacd4

Signed-off-by: yronglin <[email protected]>

[libc++] Introduce __core_convertible_to and make this paper as a C++…

f69fb88

…26 feature Signed-off-by: yronglin <[email protected]>

yronglin force-pushed the P3379R0 branch from 20fb88f to f69fb88 Compare April 22, 2025 14:37

H-G-Hristov reviewed Apr 22, 2025

View reviewed changes

libcxx/include/__cxx03/module.modulemap Outdated Show resolved Hide resolved

yronglin added 2 commits April 23, 2025 00:10

[libc++] Remove changes in cxx0f modulemap file

72e6101

Signed-off-by: yronglin <[email protected]>

Merge remote-tracking branch 'llorg/main' into P3379R0

a428d4a

frederick-vs-ja reviewed Apr 23, 2025

View reviewed changes

libcxx/include/__concepts/core_convertible_to.h Outdated Show resolved Hide resolved

philnik777 reviewed Apr 23, 2025

View reviewed changes

libcxx/include/__concepts/core_convertible_to.h Outdated Show resolved Hide resolved

yronglin and others added 2 commits April 23, 2025 22:52

Update libcxx/include/__concepts/core_convertible_to.h

7754d35

Co-authored-by: A. Jiang <[email protected]>

[libc++] Move __core_convertible_to into __type_traits/is_core_conver…

3e0f49e

…tible.h Signed-off-by: yronglin <[email protected]>

yronglin added 3 commits April 24, 2025 22:20

[NFC][libc++] Format

860ad25

Signed-off-by: yronglin <[email protected]>

[libc++] Fix build errors

fe542c0

Signed-off-by: yronglin <[email protected]>

Merge branch 'main' into P3379R0

912176f

Zingam reviewed Apr 24, 2025

View reviewed changes

llvm/utils/gn/secondary/libcxx/include/BUILD.gn Outdated Show resolved Hide resolved

yronglin added 2 commits April 25, 2025 08:59

[libc++] Remove __concepts/core_convertible_to.h in BUILD.gn

e94e3c9

Signed-off-by: yronglin <[email protected]>

Merge branch 'main' into P3379R0

7b69015

frederick-vs-ja requested changes Apr 25, 2025

View reviewed changes

libcxx/test/std/utilities/expected/expected.void/equality/equality.unexpected.pass.cpp Outdated Show resolved Hide resolved

[libc++] Fix test

58cfc99

Signed-off-by: yronglin <[email protected]>

yronglin requested a review from frederick-vs-ja April 26, 2025 05:33

huixie90 reviewed Apr 26, 2025

View reviewed changes

Zingam reviewed Apr 29, 2025

View reviewed changes

libcxx/include/__expected/expected.h Outdated Show resolved Hide resolved

Zingam reviewed Apr 29, 2025

View reviewed changes

libcxx/include/__expected/expected.h Outdated Show resolved Hide resolved

yronglin added 2 commits April 29, 2025 20:00

[libc++] Remove empty line

300eefa

Signed-off-by: yronglin <[email protected]>

Merge branch 'main' into P3379R0

8b966b6

H-G-Hristov mentioned this pull request Apr 30, 2025

P2944R3: Constrained equality - set FTM __cpp_lib_constrained_equality #136770

Open

Zingam mentioned this pull request May 2, 2025

P2944R3: Update comparisons for reference_wrapper #138233

Open

frederick-vs-ja approved these changes May 2, 2025

View reviewed changes

ldionne approved these changes May 7, 2025

View reviewed changes

ldionne merged commit 13c464b into llvm:main May 7, 2025
85 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libc++] Implement P3379R0 Constrain `std::expected` equality operators #135759

[libc++] Implement P3379R0 Constrain `std::expected` equality operators #135759

yronglin commented Apr 15, 2025 •

edited

Loading

llvmbot commented Apr 15, 2025

Zingam commented Apr 15, 2025

yronglin commented Apr 15, 2025

H-G-Hristov commented Apr 22, 2025

github-actions bot commented Apr 24, 2025 •

edited

Loading

huixie90 Apr 26, 2025

frederick-vs-ja Apr 26, 2025 •

edited

Loading

huixie90 May 3, 2025

frederick-vs-ja May 3, 2025

frederick-vs-ja May 4, 2025

[libc++] Implement P3379R0 Constrain std::expected equality operators #135759

[libc++] Implement P3379R0 Constrain std::expected equality operators #135759

Conversation

yronglin commented Apr 15, 2025 • edited Loading

llvmbot commented Apr 15, 2025

Zingam commented Apr 15, 2025

yronglin commented Apr 15, 2025

H-G-Hristov commented Apr 22, 2025

github-actions bot commented Apr 24, 2025 • edited Loading

huixie90 Apr 26, 2025

Choose a reason for hiding this comment

frederick-vs-ja Apr 26, 2025 • edited Loading

Choose a reason for hiding this comment

huixie90 May 3, 2025

Choose a reason for hiding this comment

frederick-vs-ja May 3, 2025

Choose a reason for hiding this comment

frederick-vs-ja May 4, 2025

Choose a reason for hiding this comment

[libc++] Implement P3379R0 Constrain `std::expected` equality operators #135759

[libc++] Implement P3379R0 Constrain `std::expected` equality operators #135759

yronglin commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

frederick-vs-ja Apr 26, 2025 •

edited

Loading