Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[libc++][test] Don't pass ill-formed UTF-8 to MAKE_STRING_VIEW #136403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libc++][test] Don't pass ill-formed UTF-8 to MAKE_STRING_VIEW #136403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ void test_string() {

// Ill-formed
if constexpr (sizeof(CharT) == 1)
test_format(SV(R"("\x{80}")"), SV("{:?}"), SV("\x80"));
test_format(SV(R"("\x{80}")"), SV("{:?}"), "\x80");

// *** P2713R1 examples ***
test_format(SV(R"(["\u{301}"])"), SV("[{:?}]"), SV("\u0301"));
Expand Down
36 changes: 23 additions & 13 deletions libcxx/test/std/utilities/format/format.functions/fill.unicode.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,30 +75,40 @@ void test() {

// Invalid Unicode Scalar Values
if constexpr (std::same_as<CharT, char>) {
check_exception("The format specifier contains malformed Unicode characters", SV("{:\xed\xa0\x80^}"), 42); // U+D800
check_exception("The format specifier contains malformed Unicode characters", SV("{:\xed\xa0\xbf^}"), 42); // U+DBFF
check_exception("The format specifier contains malformed Unicode characters", SV("{:\xed\xbf\x80^}"), 42); // U+DC00
check_exception("The format specifier contains malformed Unicode characters", SV("{:\xed\xbf\xbf^}"), 42); // U+DFFF
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xed\xa0\x80^}"},
42); // U+D800
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xed\xa0\xbf^}"},
42); // U+DBFF
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xed\xbf\x80^}"},
42); // U+DC00
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xed\xbf\xbf^}"},
42); // U+DFFF

check_exception(
"The format specifier contains malformed Unicode characters", SV("{:\xf4\x90\x80\x80^}"), 42); // U+110000
check_exception(
"The format specifier contains malformed Unicode characters", SV("{:\xf4\x90\xbf\xbf^}"), 42); // U+11FFFF
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xf4\x90\x80\x80^}"},
42); // U+110000
check_exception("The format specifier contains malformed Unicode characters",
std::string_view{"{:\xf4\x90\xbf\xbf^}"},
42); // U+11FFFF

check_exception("The format specifier contains malformed Unicode characters",
SV("{:\x80^}"),
std::string_view{"{:\x80^}"},
42); // Trailing code unit with no leading one.
check_exception("The format specifier contains malformed Unicode characters",
SV("{:\xc0^}"),
std::string_view{"{:\xc0^}"},
42); // Missing trailing code unit.
check_exception("The format specifier contains malformed Unicode characters",
SV("{:\xe0\x80^}"),
std::string_view{"{:\xe0\x80^}"},
42); // Missing trailing code unit.
check_exception("The format specifier contains malformed Unicode characters",
SV("{:\xf0\x80^}"),
std::string_view{"{:\xf0\x80^}"},
42); // Missing two trailing code units.
check_exception("The format specifier contains malformed Unicode characters",
SV("{:\xf0\x80\x80^}"),
std::string_view{"{:\xf0\x80\x80^}"},
42); // Missing trailing code unit.

#ifndef TEST_HAS_NO_WIDE_CHARACTERS
Expand Down
Loading