Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[llvm] annotate interfaces in llvm/Analysis for DLL export #136623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrurogerz
Copy link
Contributor

@andrurogerz andrurogerz commented Apr 21, 2025

Purpose

This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch annotates the llvm/Analysis library. These annotations currently have no meaningful impact on the LLVM build; however, they are a prerequisite to support an LLVM Windows DLL (shared library) build.

Background

This effort is tracked in #109483. Additional context is provided in this discourse, and documentation for LLVM_ABI and related annotations is found in the LLVM repo here.

The bulk of these changes were generated automatically using the Interface Definition Scanner (IDS) tool, followed formatting with git clang-format.

The following manual adjustments were also applied after running IDS on Linux:

  • Add #include "llvm/Support/Compiler.h" to files where it was not auto-added by IDS due to no pre-existing block of include statements.
  • Add LLVM_ABI to Windows-only code (auto generated with IDS on Windows)
  • Explicitly make classes non-copyable where needed to due IDS adding LLVM_ABI at the class level
  • Add LLVM_TEMPLATE_ABI and LLVM_EXPORT_TEMPLATE to exported instantiated templates
  • Add LLVM_ABI_FRIEND to a small number of friend function declarations
  • Add LLVM_ABI to a subset of private class methods and fields that require export
  • Add LLVM_ABI to a small number of symbols that require export but are not declared in headers
  • Add LLVM_ABI functions defined via X-macro

Validation

Local builds and tests to validate cross-platform compatibility. This included llvm, clang, and lldb on the following configurations:

  • Windows with MSVC
  • Windows with Clang
  • Linux with GCC
  • Linux with Clang
  • Darwin with Clang

Copy link

github-actions bot commented Apr 21, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@andrurogerz andrurogerz force-pushed the llvmdll-lib-Analysis branch 3 times, most recently from d192f16 to ccf4b8d Compare April 22, 2025 23:35
@andrurogerz andrurogerz force-pushed the llvmdll-lib-Analysis branch from ccf4b8d to 52e1d0c Compare May 6, 2025 21:39
@andrurogerz andrurogerz force-pushed the llvmdll-lib-Analysis branch from 52e1d0c to 405cfbf Compare May 6, 2025 21:42
@andrurogerz andrurogerz force-pushed the llvmdll-lib-Analysis branch from 405cfbf to da2bc32 Compare May 6, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant