[CodeGen][Pass] Add TargetPassBuilder
#137290
Conversation
|
But there are no virtual methods, so are we removing distinct phases (like |
IMHO some phases here is not clear, the example is pre emit, we have
Yeah pre isel is one of phases To be more radical, I even want to use type erasure to ensure backends only add dag isel and asm printer to replace the |
22d7f27 to
b34d27c
Compare
d9d61ec to
d30808d
Compare
d30808d to
5e3864a
Compare
5e3864a to
b4867b3
Compare
|
Support dummy injection points now, they are PreISel, PostBBSections and PreEmit. |
|
Instead of force pushing, can you keep separate commits each time you add a new patch? It would be easier to identify the new changes coming in. |
This implementation supports
--start/stop-before/afteroptions by hijacking original pass managers. With injected-class-name, user should not feel any difference from original pass manager in most cases.Except virtual functions to add necessary passes (e.g. instruction select pass), the only method to extend the pipeline is
injectBefore, which accept a callback to extend pipeline at the specified point. The return type of the callback is depend on the selected passinjectBefore<SomeFunctionPass>([](){ FunctionPassManager FPM; // Add passes you want. return FPM; }); // If you really want to add module pass between machine function passes... injectBefore<SomeMachineFunctionPass, ModulePassManager>([](){ ModulePassManager MPM; MachineFunctionPass MFPM; // Add passes you want. MPM.createModuleToFunctionPassAdaptor(createFunctionToMachineFunctionPassAdaptor(std::move(MFPM))); return MPM; });