[libc][math][c23] Add rsqrtf16() function #137545
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Defined and declared rsqrtf16 - Added entrypoints to support rsqrt in float16 format - Added tests - both unit and exhaustive - Added MPFR support for Rsqrt to verify the test results TODO: - Write computation as a polynomial in the end of rsqrtf16.cpp - Check if errors are generated correctly (Reference from C23: The rsqrt functions compute the reciprocal of the nonnegative square root of the argument. A domain error occurs if the argument is less than zero. A pole error may occur if the argument equals zero.)
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Trying to figure out what would be the best option to compute the result. Also found this already existing implementation: It has some other interesting points that I found when I was doing my research: specifically, Newton's method. I tried adding one iteration of it, but same: it didn't help much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #132818
Part of #95250