[DSE] Simpily if condition (NFC) #137777
Merged
[DSE] Simpily if condition (NFC) #137777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-transforms Author: None (NewSigma) ChangesNote that the key-value pair has already been initialized, so assignment is not necessary. Full diff: https://github.com/llvm/llvm-project/pull/137777.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
index 0521df8b818cf..ce210fc26a871 100644
--- a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
@@ -1210,13 +1210,11 @@ struct DSEState {
bool isInvisibleToCallerAfterRet(const Value *V) {
if (isa<AllocaInst>(V))
return true;
+
auto I = InvisibleToCallerAfterRet.insert({V, false});
if (I.second) {
- if (!isInvisibleToCallerOnUnwind(V)) {
- I.first->second = false;
- } else if (isNoAliasCall(V)) {
+ if (isInvisibleToCallerOnUnwind(V) && isNoAliasCall(V))
I.first->second = !PointerMayBeCaptured(V, /*ReturnCaptures=*/true);
- }
}
return I.first->second;
}
|
fhahn
reviewed
Apr 29, 2025
| @@ -1210,13 +1210,11 @@ struct DSEState { | |||
| bool isInvisibleToCallerAfterRet(const Value *V) { | |||
| if (isa<AllocaInst>(V)) | |||
| return true; | |||
|
|
|||
There was a problem hiding this comment.
Break a line for better readability. Feel free to tell me if it should not appear in this patch.
nikic
approved these changes
Apr 29, 2025
|
Thanks to fhahn and nikic for the code review. Could you please help merge it if everything looks good? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/17723 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Note that the key-value pair has already been initialized, so assignment is not necessary.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Note that the key-value pair has already been initialized, so assignment is not necessary.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Note that the key-value pair has already been initialized, so assignment is not necessary.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Note that the key-value pair has already been initialized, so assignment is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the key-value pair has already been initialized, so assignment is not necessary.