[BOLT][test] Disable callcont-fallthru.s on AArch64 #137831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-bolt Author: Paschalis Mpeis (paschalis-mpeis) ChangesDisabling this test on AArch64, until a consistent workaround is in place. See this comment of:
Full diff: https://github.com/llvm/llvm-project/pull/137831.diff 1 Files Affected:
diff --git a/bolt/test/X86/callcont-fallthru.s b/bolt/test/X86/callcont-fallthru.s
index ee72d8f62e032..329cc9530bd68 100644
--- a/bolt/test/X86/callcont-fallthru.s
+++ b/bolt/test/X86/callcont-fallthru.s
@@ -1,6 +1,8 @@
## Ensures that a call continuation fallthrough count is set when using
## pre-aggregated perf data.
+# REQUIRES: x86_64-linux
+
# RUN: %clang %cflags -fpic -shared -xc /dev/null -o %t.so
## Link against a DSO to ensure PLT entries.
# RUN: %clangxx %cxxflags %s %t.so -o %t -Wl,-q -nostdlib
|
|
(continuing discussion to this PR) Quoting @yota9 from #135867 comment:
Great, thank you! @aaupov, are you happy hitting the green button here? I've added a note to make sure we follow-up after #138232: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling this test on AArch64, until a consistent workaround is in place. See this comment of:
This would help unblock our buildbot (currently internal, but with plans of adding it to LLVM).