[NFC][clang] No sharedlibs for UEFI #137872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain.
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Prabhu Rajasekaran (Prabhuk) ChangesThere is no support for shared libraries for UEFI target. Remove the Full diff: https://github.com/llvm/llvm-project/pull/137872.diff 2 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/UEFI.cpp b/clang/lib/Driver/ToolChains/UEFI.cpp
index a9d7e7892c5a6..fbef72e34a3b1 100644
--- a/clang/lib/Driver/ToolChains/UEFI.cpp
+++ b/clang/lib/Driver/ToolChains/UEFI.cpp
@@ -80,9 +80,6 @@ void tools::uefi::Linker::ConstructJob(Compilation &C, const JobAction &JA,
// "Terminal Service Aware" flag is not needed for UEFI applications.
CmdArgs.push_back("-tsaware:no");
- // EFI_APPLICATION to be linked as DLL by default.
- CmdArgs.push_back("-dll");
-
if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7))
CmdArgs.push_back("-debug");
diff --git a/clang/test/Driver/uefi-constructed-args.c b/clang/test/Driver/uefi-constructed-args.c
index 44d2271e0c8ba..49ede47a8953e 100644
--- a/clang/test/Driver/uefi-constructed-args.c
+++ b/clang/test/Driver/uefi-constructed-args.c
@@ -11,5 +11,4 @@
// CHECK-SAME: "-subsystem:efi_application"
// CHECK-SAME: "-entry:EfiMain"
// CHECK-SAME: "-tsaware:no"
-// CHECK-SAME: "-dll"
// CHECK-SAME: "-debug"
|
petrhosek
approved these changes
Apr 29, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no support for shared libraries for UEFI target. Remove the
incorrect -dll flag set from UEFI toolchain.