[X86][NFC] Remove duplicate feature from Znver5 processor definition #137901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FeatureVNNI` is already in Znver4AdditionalFeature.
|
@llvm/pr-subscribers-backend-x86 Author: Min-Yih Hsu (mshockwave) Changes
Found by the new TableGen warning introduced in 951292b Full diff: https://github.com/llvm/llvm-project/pull/137901.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86.td b/llvm/lib/Target/X86/X86.td
index 574624291c01b..2d635835e3ff7 100644
--- a/llvm/lib/Target/X86/X86.td
+++ b/llvm/lib/Target/X86/X86.td
@@ -1591,8 +1591,7 @@ def ProcessorFeatures {
!listconcat(ZN3Features, ZN4AdditionalFeatures);
list<SubtargetFeature> ZN5Tuning = ZN4Tuning;
- list<SubtargetFeature> ZN5AdditionalFeatures = [FeatureVNNI,
- FeatureMOVDIRI,
+ list<SubtargetFeature> ZN5AdditionalFeatures = [FeatureMOVDIRI,
FeatureMOVDIR64B,
FeatureVP2INTERSECT,
FeaturePREFETCHI,
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/17720 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#137901) `FeatureVNNI` is already in Znver4AdditionalFeature. Found by the new TableGen warning introduced in 951292b
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#137901) `FeatureVNNI` is already in Znver4AdditionalFeature. Found by the new TableGen warning introduced in 951292b
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#137901) `FeatureVNNI` is already in Znver4AdditionalFeature. Found by the new TableGen warning introduced in 951292b
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…lvm#137901) `FeatureVNNI` is already in Znver4AdditionalFeature. Found by the new TableGen warning introduced in 951292b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureVNNIis already in Znver4AdditionalFeature.Found by the new TableGen warning introduced in 951292b