[AMDGPU][NFC] Remove duplicate features in gfx908/909/90a #137902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-amdgpu Author: Min-Yih Hsu (mshockwave) ChangesThe new TableGen warning introduced in 951292b shows the following warnings: Full diff: https://github.com/llvm/llvm-project/pull/137902.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPU.td b/llvm/lib/Target/AMDGPU/AMDGPU.td
index d896589825fc7..764a7a9bf5e52 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPU.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPU.td
@@ -1534,8 +1534,7 @@ def FeatureISAVersion9_Generic : FeatureSet<
def FeatureISAVersion9_0_MI_Common : FeatureSet<
!listconcat(FeatureISAVersion9_0_Common.Features,
- [FeatureAddressableLocalMemorySize65536,
- FeatureFmaMixInsts,
+ [FeatureFmaMixInsts,
FeatureDLInsts,
FeatureDot1Insts,
FeatureDot2Insts,
@@ -1585,8 +1584,7 @@ def FeatureISAVersion9_0_8 : FeatureSet<
def FeatureISAVersion9_0_9 : FeatureSet<
!listconcat(FeatureISAVersion9_0_Consumer_Common.Features,
- [FeatureMadMixInsts,
- FeatureImageInsts])>;
+ [FeatureMadMixInsts])>;
def FeatureISAVersion9_0_A : FeatureSet<
!listconcat(FeatureISAVersion9_0_MI_Common.Features,
|
shiltian
approved these changes
Apr 30, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor gfx908 contains duplicate feature 'addressablelocalmemorysize65536' warning: Processor gfx909 contains duplicate feature 'image-insts' warning: Processor gfx90a contains duplicate feature 'addressablelocalmemorysize65536' ```
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor gfx908 contains duplicate feature 'addressablelocalmemorysize65536' warning: Processor gfx909 contains duplicate feature 'image-insts' warning: Processor gfx90a contains duplicate feature 'addressablelocalmemorysize65536' ```
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor gfx908 contains duplicate feature 'addressablelocalmemorysize65536' warning: Processor gfx909 contains duplicate feature 'image-insts' warning: Processor gfx90a contains duplicate feature 'addressablelocalmemorysize65536' ```
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor gfx908 contains duplicate feature 'addressablelocalmemorysize65536' warning: Processor gfx909 contains duplicate feature 'image-insts' warning: Processor gfx90a contains duplicate feature 'addressablelocalmemorysize65536' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TableGen warning introduced in 951292b shows the following warnings: