Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flang] Fix build when examples are disabled #137908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arichardson
Copy link
Member

Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Created using spr 1.3.6-beta.1
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Apr 30, 2025
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I haven't tested it).

@arichardson arichardson merged commit e4332e4 into main Apr 30, 2025
13 checks passed
@arichardson arichardson deleted the users/arichardson/spr/flang-fix-build-when-examples-are-disabled branch April 30, 2025 05:42
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Reviewed By: mgorny

Pull Request: llvm#137908
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Reviewed By: mgorny

Pull Request: llvm#137908
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Reviewed By: mgorny

Pull Request: llvm#137908
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request May 6, 2025
Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Reviewed By: mgorny

Pull Request: llvm/llvm-project#137908
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
Without this change I get a build error due to the missing Bye target
when I configure my build with -DLLVM_INCLUDE_EXAMPLES=OFF.
This check for LLVM_BUILD_EXAMPLES matches the checks in llvm and lld.

Reviewed By: mgorny

Pull Request: llvm#137908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants