Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flang] Move LLVM_ENABLE_RUNTIMES definition above uses #138136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

[flang] Move LLVM_ENABLE_RUNTIMES definition above uses #138136

merged 1 commit into from
May 1, 2025

Conversation

DavidTruby
Copy link
Member

This fixes an issue where flang-rt was not getting automatically added
to LLVM_ENABLE_RUNTIMES because LLVM_ENABLE_RUNTIMES had not been
defined yet.

@DavidTruby
[flang] Move LLVM_ENABLE_RUNTIMES definition above uses
b025dff 
This fixes an issue where flang-rt was not getting automatically added
to LLVM_ENABLE_RUNTIMES because LLVM_ENABLE_RUNTIMES had not been
defined yet.
@DavidTruby DavidTruby requested a review from Meinersbur May 1, 2025 14:08
@DavidTruby DavidTruby mentioned this pull request May 1, 2025
Merged
@DavidTruby DavidTruby requested a review from tblah May 1, 2025 14:09
@tblah tblah requested a review from dpalermo May 1, 2025 15:07
dpalermo
dpalermo approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@dpalermo dpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@clementval
Copy link
Contributor

I had the same issue yesterday. Thanks for fixing this.

@DavidTruby DavidTruby merged commit 0a4be78 into llvm:main May 1, 2025
12 checks passed
@Meinersbur
Copy link
Member

Thanks for the fix

@llvm-ci
Copy link
Collaborator

llvm-ci commented May 2, 2025

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2831

Here is the relevant piece of the build log for the reference 
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/90/95' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-20552-90-95.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=95 GTEST_SHARD_INDEX=90 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************

IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
@DavidTruby @IanWood1
[flang] Move LLVM_ENABLE_RUNTIMES definition above uses (llvm#138136)
ab39b6c
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
@DavidTruby @IanWood1
[flang] Move LLVM_ENABLE_RUNTIMES definition above uses (llvm#138136)
1578b73
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
@DavidTruby @IanWood1
[flang] Move LLVM_ENABLE_RUNTIMES definition above uses (llvm#138136)
b36775a
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
@DavidTruby @GeorgeARM
[flang] Move LLVM_ENABLE_RUNTIMES definition above uses (llvm#138136)
e14055b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpalermo dpalermo dpalermo approved these changes

@Meinersbur Meinersbur Awaiting requested review from Meinersbur

@tblah tblah Awaiting requested review from tblah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DavidTruby @clementval @Meinersbur @llvm-ci @dpalermo