Print source filename when invalid debug info is found in LTO. #138201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invalid debug info is found in a module during LTO, the debug info from that module is stripped. However, we do not print the source filename, which makes it impossible to figure out where the invalid debug info is coming from. This patch prints the source file name.
|
@llvm/pr-subscribers-lto Author: Shubham Sandeep Rastogi (rastogishubham) ChangesWhen invalid debug info is found in a module during LTO, the debug info from that module is stripped. However, we do not print the source filename, which makes it impossible to figure out where the invalid debug info is coming from. This patch prints the source file name. Full diff: https://github.com/llvm/llvm-project/pull/138201.diff 2 Files Affected:
diff --git a/llvm/lib/LTO/LTOCodeGenerator.cpp b/llvm/lib/LTO/LTOCodeGenerator.cpp
index 70b7135fcbef0..bd0dfed76e3d4 100644
--- a/llvm/lib/LTO/LTOCodeGenerator.cpp
+++ b/llvm/lib/LTO/LTOCodeGenerator.cpp
@@ -548,6 +548,7 @@ void LTOCodeGenerator::verifyMergedModuleOnce() {
report_fatal_error("Broken module found, compilation aborted!");
if (BrokenDebugInfo) {
emitWarning("Invalid debug info found, debug info will be stripped");
+ emitWarning("Source FileName: " + MergedModule->getSourceFileName());
StripDebugInfo(*MergedModule);
}
}
diff --git a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
index 42dba0abe245f..5c4883c8ddae9 100644
--- a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
+++ b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp
@@ -182,6 +182,8 @@ static void verifyLoadedModule(Module &TheModule) {
if (BrokenDebugInfo) {
TheModule.getContext().diagnose(ThinLTODiagnosticInfo(
"Invalid debug info found, debug info will be stripped", DS_Warning));
+ TheModule.getContext().diagnose(ThinLTODiagnosticInfo(
+ "Source File Name: " + TheModule.getSourceFileName(), DS_Warning));
StripDebugInfo(TheModule);
}
}
|
| @@ -182,6 +182,8 @@ static void verifyLoadedModule(Module &TheModule) { | |||
| if (BrokenDebugInfo) { | |||
| TheModule.getContext().diagnose(ThinLTODiagnosticInfo( | |||
| "Invalid debug info found, debug info will be stripped", DS_Warning)); | |||
| TheModule.getContext().diagnose(ThinLTODiagnosticInfo( | |||
| "Source File Name: " + TheModule.getSourceFileName(), DS_Warning)); | |||
There was a problem hiding this comment.
the formatting is inconsistent with the one above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invalid debug info is found in a module during LTO, the debug info from that module is stripped. However, we do not print the source filename, which makes it impossible to figure out where the invalid debug info is coming from.
This patch prints the source file name.