-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[NFC] Fix c++ style comment in c file #138244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.
@llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-clang Author: Björn Pettersson (bjope) ChangesFix "C++ style comments are not allowed in ISO C90" warnings in some C files. Full diff: https://github.com/llvm/llvm-project/pull/138244.diff 2 Files Affected:
diff --git a/clang/tools/c-index-test/c-index-test.c b/clang/tools/c-index-test/c-index-test.c
index 7711df3fd9209..ee4a2f37fbc5d 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -1224,7 +1224,7 @@ static CXString createCXString(const char *CS) {
static CXString duplicateCXString(const char *CS) {
CXString Str;
Str.data = strdup(CS);
- Str.private_flags = 1; // CXS_Malloc
+ Str.private_flags = 1; /* CXS_Malloc */
return Str;
}
diff --git a/llvm/include/llvm/Support/AutoConvert.h b/llvm/include/llvm/Support/AutoConvert.h
index 5d6d9394ef1d8..352493e9be25f 100644
--- a/llvm/include/llvm/Support/AutoConvert.h
+++ b/llvm/include/llvm/Support/AutoConvert.h
@@ -55,14 +55,16 @@ std::error_code restorezOSStdHandleAutoConversion(int FD);
/** \brief Set the tag information for a file descriptor. */
std::error_code setzOSFileTag(int FD, int CCSID, bool Text);
-// Get the the tag ccsid for a file name or a file descriptor.
+/** \brief Get the the tag ccsid for a file name or a file descriptor. */
ErrorOr<__ccsid_t> getzOSFileTag(const char *FileName, const int FD = -1);
-// Query the file tag to determine if it needs conversion to UTF-8 codepage.
+/** \brief Query the file tag to determine if it needs conversion to UTF-8
+ * codepage.
+ */
ErrorOr<bool> needzOSConversion(const char *FileName, const int FD = -1);
-} // namespace llvm
-#endif // __cplusplus
+} /* namespace llvm */
+#endif /* __cplusplus */
#endif /* __MVS__ */
|
abhina-sree
approved these changes
May 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "C++ style comments are not allowed in ISO C90" warnings in some C files.