[llvm] Allow Fast and Tail CC in UEFI #138361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow tail call and fastcc optimizations for UEFI X86_64 targets.
|
@llvm/pr-subscribers-backend-x86 Author: Prabhu Rajasekaran (Prabhuk) ChangesAllow tail call and fastcc optimizations for UEFI X86_64 targets. Full diff: https://github.com/llvm/llvm-project/pull/138361.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86Subtarget.h b/llvm/lib/Target/X86/X86Subtarget.h
index a0b182d3f4c9b..c2b7d3780a983 100644
--- a/llvm/lib/Target/X86/X86Subtarget.h
+++ b/llvm/lib/Target/X86/X86Subtarget.h
@@ -352,9 +352,9 @@ class X86Subtarget final : public X86GenSubtargetInfo {
switch (CC) {
// On Win64, all these conventions just use the default convention.
case CallingConv::C:
- return isTargetWin64() || isTargetUEFI64();
case CallingConv::Fast:
case CallingConv::Tail:
+ return isTargetWin64() || isTargetUEFI64();
case CallingConv::Swift:
case CallingConv::SwiftTail:
case CallingConv::X86_FastCall:
|
|
test coverage? |
Thank you. Added tests. One of the tests will fail until #138602 lands. |
petrhosek
reviewed
May 6, 2025
petrhosek
approved these changes
May 6, 2025
petrhosek
approved these changes
May 6, 2025
RossComputerGuy
approved these changes
May 6, 2025
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Allow tail call and fastcc optimizations for UEFI X86_64 targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tail call and fastcc optimizations for UEFI X86_64 targets.