Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SelectionDAG] Remove obsolete comments (NFC) #138483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

@kazutakahirata kazutakahirata commented May 5, 2025

These functions do not return boolean values.

These fucntions do not return boolean values.
@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label May 5, 2025
@llvmbot
Copy link
Member

llvmbot commented May 5, 2025

@llvm/pr-subscribers-llvm-selectiondag

Author: Kazu Hirata (kazutakahirata)

Changes

These fucntions do not return boolean values.


Full diff: https://github.com/llvm/llvm-project/pull/138483.diff

1 Files Affected:

  • (modified) llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp (+2-8)
diff --git a/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp b/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp
index 30f65bde142d2..0a6ee1613b6bf 100644
--- a/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp
@@ -80,16 +80,10 @@ class ScheduleDAGFast : public ScheduleDAGSDNodes {
   void Schedule() override;
 
   /// AddPred - adds a predecessor edge to SUnit SU.
-  /// This returns true if this is a new predecessor.
-  void AddPred(SUnit *SU, const SDep &D) {
-    SU->addPred(D);
-  }
+  void AddPred(SUnit *SU, const SDep &D) { SU->addPred(D); }
 
   /// RemovePred - removes a predecessor edge from SUnit SU.
-  /// This returns true if an edge was removed.
-  void RemovePred(SUnit *SU, const SDep &D) {
-    SU->removePred(D);
-  }
+  void RemovePred(SUnit *SU, const SDep &D) { SU->removePred(D); }
 
 private:
   void ReleasePred(SUnit *SU, SDep *PredEdge);

@kazutakahirata kazutakahirata merged commit f81193d into llvm:main May 5, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_comments_void_return branch May 5, 2025 17:19
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
These functions do not return boolean values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:SelectionDAG SelectionDAGISel as well
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants