[OpenMP] Use TLS for gtid on Solaris#138508
Merged
Conversation
When running the `openmp` testsuite on Solaris/amd64, many tests `FAIL` like ``` # | OMP: Error llvm#11: Stack overflow detected for OpenMP thread #1 ``` In a `Debug` build, I also get ``` # | Assertion failure at kmp_runtime.cpp(203): __kmp_gtid_get_specific() < 0 || __kmp_gtid_get_specific() == i. ``` Further investigation shows that just setting `__kmp_gtid_mode` to 3 massively reduced the number of failures. Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
Collaborator
Author
|
@psumbera This is just the first in a series of patches fixing |
brad0
approved these changes
May 6, 2025
MaskRay
approved these changes
May 6, 2025
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
When running the `openmp` testsuite on Solaris/amd64, many tests `FAIL` like ``` # | OMP: Error llvm#11: Stack overflow detected for OpenMP thread llvm#1 ``` In a `Debug` build, I also get ``` # | Assertion failure at kmp_runtime.cpp(203): __kmp_gtid_get_specific() < 0 || __kmp_gtid_get_specific() == i. ``` Further investigation shows that just setting `__kmp_gtid_mode` to 3 massively reduces the number of failures. Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the
openmptestsuite on Solaris/amd64, many testsFAILlikeIn a
Debugbuild, I also getFurther investigation shows that just setting
__kmp_gtid_modeto 3 massively reduces the number of failures.Tested on
amd64-pc-solaris2.11andx86_64-pc-linux-gnu.