Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OpenMP] Provide __kmp_unnamed_critical_addr on SPARC #138517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

[OpenMP] Provide __kmp_unnamed_critical_addr on SPARC #138517

merged 1 commit into from
May 6, 2025

Conversation

rorth
Copy link
Collaborator

@rorth rorth commented May 5, 2025

libomp.so currently fails to link on SPARC, both Solaris/sparcv9 and Linux/sparc64:

Undefined                       first referenced
 symbol                             in file
__kmp_unnamed_critical_addr         projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_gsupport.cpp.o
ld: fatal: symbol referencing errors

This patch provides the necessary definition. While at it, I noticed that on non-x86 targets the symbol wasn't marked as @object, which this patch corrects, too.

Tested on sparcv9-sun-solaris2.11, sparc64-unknown-linux-gnu, amd64-pc-solaris2.11, and x86_64-pc-linux-gnu.

@rorth
[OpenMP] Provide __kmp_unnamed_critical_addr on SPARC
a67ef91 
`libomp.so` currently fails to link on SPARC, both Solaris/sparcv9 and
Linux/sparc64:

```
Undefined                       first referenced
 symbol                             in file
__kmp_unnamed_critical_addr         projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_gsupport.cpp.o
ld: fatal: symbol referencing errors
```

This patch provides the necessary definition.  While at it, I noticed that
on non-x86 targets the symbol wasn't marked as `@object`, which this patch
corrects, too.

Tested on `sparcv9-sun-solaris2.11`, `sparc64-unknown-linux-gnu`,
`amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
@rorth rorth requested review from mstorsjo and brad0 May 5, 2025 12:23
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label May 5, 2025
@rorth rorth merged commit c24b9ca into llvm:main May 6, 2025
11 checks passed
@Sharjeel-Khan
Copy link
Contributor

Sharjeel-Khan commented May 6, 2025 •
edited
Loading

This change caused an error in Android's LLVM builders:

[5/35] Building ASM object runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o
FAILED: runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o 
/b/f/w/src/git/out/stage2-install/bin/clang --sysroot=/b/f/w/src/git/out/sysroots/platform/arm  -I/b/f/w/src/git/out/lib/libomp-arm-static/runtime/src -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/i18n -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/include -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/thirdparty/ittnotify -I/b/f/w/src/git/out/llvm-project/openmp/runtime/src/android -ffile-prefix-map=/b/f/w/src/git/= --target=armv7a-linux-androideabi30 -ffunction-sections -fdata-sections -march=armv7-a -D_LIBCPP_AVAILABILITY_HAS_NO_VERBOSE_ABORT=1 --sysroot=/b/f/w/src/git/out/sysroots/platform/arm -O3 -DNDEBUG -fPIC   -D _GNU_SOURCE -D _REENTRANT -D LIBOMP_HAVE_PTHREAD_SETNAME_NP -U_GLIBCXX_ASSERTIONS -MD -MT runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o -MF runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o.d -o runtime/src/CMakeFiles/omp.dir/z_Linux_asm.S.o -c /b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S
/[b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S:2485](https://cs.corp.google.com/piper///depot/google3/b/f/w/src/git/out/llvm-project/openmp/runtime/src/z_Linux_asm.S?l=2485):39: error: expected STT_<TYPE_IN_UPPER_CASE>, '#<type>', '%<type>' or "<type>"
    .type __kmp_unnamed_critical_addr,@object
                                                                   ^

I want to check if this error is a mistake from our build scripts or the change.

@rorth
Copy link
Collaborator Author

rorth commented May 7, 2025

It's my fault, unfortunately: I'd forgotten that while the @object form works on the vast majority of ELF targets, ARM/AArch64 is the odd man out. This can be seen in the .section .note.GNU-stack definition a few lines below. I've found
that on all targets currently supported by z_Linux_asm.S, one can assemble %object instead. I'll post a (very lightly) tested patch shortly.

@mstorsjo
Copy link
Member

mstorsjo commented May 7, 2025

It's my fault, unfortunately: I'd forgotten that while the @object form works on the vast majority of ELF targets, ARM/AArch64 is the odd man out.

I think this is only the case for ARM, not AArch64. The reason is that @ is treated as default assembler comment character there - but this isn't the case for AArch64.

rorth added a commit to rorth/llvm-project that referenced this pull request May 7, 2025
@rorth
[OpenMP] Fix __kmp_unnamed_critical_addr .type setting
e9c4156 
PR llvm#138517 broke the Android LLVM builders: ARM doesn't understand the
`@object` form.  As it turns out, one can use `%object` instead, which does
assemble on all targets currently supported by `z_Linux_asm.S`.

Tested by rebuilding `libomp.so` on `sparcv9-sun-solaris2.11`.
@rorth
Copy link
Collaborator Author

rorth commented May 7, 2025

Seems so, still %object assembles on both.

@rorth rorth mentioned this pull request May 7, 2025
Merged
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
@rorth @GeorgeARM
[OpenMP] Provide __kmp_unnamed_critical_addr on SPARC (llvm#138517)
7cf99f7 
`libomp.so` currently fails to link on SPARC, both Solaris/sparcv9 and
Linux/sparc64:

```
Undefined                       first referenced
 symbol                             in file
__kmp_unnamed_critical_addr         projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_gsupport.cpp.o
ld: fatal: symbol referencing errors
```

This patch provides the necessary definition. While at it, I noticed
that on non-x86 targets the symbol wasn't marked as `@object`, which
this patch corrects, too.

Tested on `sparcv9-sun-solaris2.11`, `sparc64-unknown-linux-gnu`,
`amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
rorth added a commit that referenced this pull request May 7, 2025
@rorth
[OpenMP] Fix __kmp_unnamed_critical_addr .type setting (#138815)
39beeb8 
PR #138517 broke the Android LLVM builders: ARM doesn't understand the
`@object` form. As it turns out, one can use `%object` instead, which
does assemble on all targets currently supported by `z_Linux_asm.S`.

Tested by rebuilding `libomp.so` on `sparcv9-sun-solaris2.11`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad0 brad0 brad0 approved these changes

@mstorsjo mstorsjo Awaiting requested review from mstorsjo

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rorth @Sharjeel-Khan @mstorsjo @brad0 @llvmbot