[OpenMP][test] Define print_possible_return_address on SPARC #138523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parts of the `openmp` testsuite currently don't build on SPARC due to the lack of a `print_possible_return_addresses` definition. This patch provides one. With it, the vast majority of tests `PASS` on Solaris/sparcv9 and, with an additional patch, on Linux/sparc64. The current definition was obtained empirically and will need additional explanation/justification. Tested on `sparcv9-sun-solaris2.11`, `sparc64-unknown-linux-gnu`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
koachan
reviewed
May 5, 2025
| // FIXME: Need to distinguish between 32 and 64-bit SPARC? | ||
| // On SPARC the NOP instruction is 4 bytes long. | ||
| // FIXME: Explain. Can use __builtin_frob_return_addr? | ||
| #define print_possible_return_addresses(addr) \ |
There was a problem hiding this comment.
Hmmm, I don't know much about how OpenMP works so, what is being passed in addr here?
Some sort of register dump struct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the
openmptestsuite currently don't build on SPARC due to the lack of aprint_possible_return_addressesdefinition.This patch provides one. With it, the vast majority of tests
PASSon Solaris/sparcv9 and, with an additional patch, on Linux/sparc64.The current definition was obtained empirically and will need additional explanation/justification.
Tested on
sparcv9-sun-solaris2.11,sparc64-unknown-linux-gnu,amd64-pc-solaris2.11, andx86_64-pc-linux-gnu.