[clang][Index] Add comment about out-of-line defaulted destructor #138640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per discussion at #125153 (comment) |
|
@llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) ChangesFull diff: https://github.com/llvm/llvm-project/pull/138640.diff 1 Files Affected:
diff --git a/clang/lib/Index/IndexingContext.h b/clang/lib/Index/IndexingContext.h
index 01bfcb9d578bc..3d0606bac90c3 100644
--- a/clang/lib/Index/IndexingContext.h
+++ b/clang/lib/Index/IndexingContext.h
@@ -44,6 +44,7 @@ class IndexingContext {
public:
IndexingContext(IndexingOptions IndexOpts, IndexDataConsumer &DataConsumer);
+ // Defaulted, but defined out of line to avoid a dependency on HeuristicResolver.h.
~IndexingContext();
const IndexingOptions &getIndexOpts() const { return IndexOpts; }
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
eeeb71e to
43335f7
Compare
shafik
approved these changes
May 6, 2025
43335f7 to
fd9739f
Compare
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.