[mlir] Use ExprASTList #138658
[mlir] Use ExprASTList #138658
Conversation
use ExprASTList
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir Author: Chanane Zaguri (chananelz) Changesuse ExprASTList Full diff: https://github.com/llvm/llvm-project/pull/138658.diff 1 Files Affected:
diff --git a/mlir/examples/toy/Ch1/include/toy/AST.h b/mlir/examples/toy/Ch1/include/toy/AST.h
index d2ba101dea5a4..e7d7e85262524 100644
--- a/mlir/examples/toy/Ch1/include/toy/AST.h
+++ b/mlir/examples/toy/Ch1/include/toy/AST.h
@@ -77,11 +77,11 @@ class NumberExprAST : public ExprAST {
/// Expression class for a literal value.
class LiteralExprAST : public ExprAST {
- std::vector<std::unique_ptr<ExprAST>> values;
+ ExprASTList values;
std::vector<int64_t> dims;
public:
- LiteralExprAST(Location loc, std::vector<std::unique_ptr<ExprAST>> values,
+ LiteralExprAST(Location loc, ExprASTList values,
std::vector<int64_t> dims)
: ExprAST(Expr_Literal, std::move(loc)), values(std::move(values)),
dims(std::move(dims)) {}
@@ -167,11 +167,11 @@ class BinaryExprAST : public ExprAST {
/// Expression class for function calls.
class CallExprAST : public ExprAST {
std::string callee;
- std::vector<std::unique_ptr<ExprAST>> args;
+ ExprASTList args;
public:
CallExprAST(Location loc, const std::string &callee,
- std::vector<std::unique_ptr<ExprAST>> args)
+ ExprASTList args)
: ExprAST(Expr_Call, std::move(loc)), callee(callee),
args(std::move(args)) {}
|
use ExprASTList