[llvm] minor revisions to export annotation macro docs #138761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd do you mind having a look at this doc revision? thanks! |
compnerd
approved these changes
May 6, 2025
| constructor and copy assignment operator will resolve the issue. | ||
| the class may require minor modification. Often, explicitly deleting the copy | ||
| constructor and copy assignment operator will resolve the issue. It may also | ||
| require an explicitly defaulted constructor. |
There was a problem hiding this comment.
I'm not sure that this is particularly helpful for the reader, but the changes here do not change that. I think that it might be better to explain that if the annotation results in errors relating to the ctor, it may be that the type needs the constructors explicitly defaulted or deleted as appropriate as the compiler needs the explicit body to instantiate so that it. can reify the ABI implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make some minor tweaks and clarifications to the
LLVM_ABIexport annotation docs.Overview
Validation
Manually inspected docs on my fork here.