-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[SelectionDAG] Handle fneg
/fabs
/fcopysign
in SimplifyDemandedBits
#139239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
el-ev
wants to merge
3
commits into
main
Choose a base branch
from
users/el-ev/populate-simplify-demanded-bits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18639,17 +18639,17 @@ define bfloat @v_fabs_bf16(bfloat %a) { | |
; GCN: ; %bb.0: | ||
; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GCN-NEXT: v_mul_f32_e32 v0, 1.0, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0x7fffffff, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GCN-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
Comment on lines
+18642
to
+18643
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kind of a regression? It should be neutral in code size and cycles, but probably should prefer a bit-op to an FP op (e.g. this avoids the mode dependency) |
||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GCN-NEXT: s_setpc_b64 s[30:31] | ||
; | ||
; GFX7-LABEL: v_fabs_bf16: | ||
; GFX7: ; %bb.0: | ||
; GFX7-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GFX7-NEXT: v_mul_f32_e32 v0, 1.0, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0x7fffffff, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GFX7-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GFX7-NEXT: s_setpc_b64 s[30:31] | ||
; | ||
|
@@ -18832,8 +18832,8 @@ define bfloat @v_fneg_fabs_bf16(bfloat %a) { | |
; GCN: ; %bb.0: | ||
; GCN-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GCN-NEXT: v_mul_f32_e32 v0, 1.0, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0x7fffffff, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GCN-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GCN-NEXT: v_xor_b32_e32 v0, 0x80000000, v0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
|
@@ -18843,8 +18843,8 @@ define bfloat @v_fneg_fabs_bf16(bfloat %a) { | |
; GFX7: ; %bb.0: | ||
; GFX7-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GFX7-NEXT: v_mul_f32_e32 v0, 1.0, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0x7fffffff, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GFX7-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GFX7-NEXT: v_xor_b32_e32 v0, 0x80000000, v0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
|
@@ -18889,23 +18889,23 @@ define amdgpu_ps i32 @s_fneg_fabs_bf16(bfloat inreg %a) { | |
; GCN-LABEL: s_fneg_fabs_bf16: | ||
; GCN: ; %bb.0: | ||
; GCN-NEXT: v_mul_f32_e64 v0, 1.0, s0 | ||
; GCN-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GCN-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
; GCN-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GCN-NEXT: v_xor_b32_e32 v0, 0x80000000, v0 | ||
; GCN-NEXT: v_lshrrev_b32_e32 v0, 16, v0 | ||
; GCN-NEXT: v_readfirstlane_b32 s0, v0 | ||
; GCN-NEXT: s_and_b32 s0, s0, 0xffff0000 | ||
; GCN-NEXT: s_bitset0_b32 s0, 31 | ||
; GCN-NEXT: s_and_b32 s0, s0, 0xffff0000 | ||
; GCN-NEXT: s_xor_b32 s0, s0, 0x80000000 | ||
; GCN-NEXT: s_lshr_b32 s0, s0, 16 | ||
; GCN-NEXT: ; return to shader part epilog | ||
; | ||
; GFX7-LABEL: s_fneg_fabs_bf16: | ||
; GFX7: ; %bb.0: | ||
; GFX7-NEXT: v_mul_f32_e64 v0, 1.0, s0 | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0x7fff0000, v0 | ||
; GFX7-NEXT: v_mul_f32_e64 v0, 1.0, |v0| | ||
; GFX7-NEXT: v_and_b32_e32 v0, 0xffff0000, v0 | ||
; GFX7-NEXT: v_xor_b32_e32 v0, 0x80000000, v0 | ||
; GFX7-NEXT: v_lshrrev_b32_e32 v0, 16, v0 | ||
; GFX7-NEXT: v_readfirstlane_b32 s0, v0 | ||
; GFX7-NEXT: s_and_b32 s0, s0, 0xffff0000 | ||
; GFX7-NEXT: s_bitset0_b32 s0, 31 | ||
; GFX7-NEXT: s_and_b32 s0, s0, 0xffff0000 | ||
; GFX7-NEXT: s_xor_b32 s0, s0, 0x80000000 | ||
; GFX7-NEXT: s_lshr_b32 s0, s0, 16 | ||
; GFX7-NEXT: ; return to shader part epilog | ||
; | ||
; GFX8-LABEL: s_fneg_fabs_bf16: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may help if we can observe test changes with the SimplifyDemandedBits changes alone, without dropping the existing combines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested locally, nothing changes when adding the removed combines back. But regressions happen when
fold (fabs (fabs x)) -> (fabs x)
at L18878-L18880 is removed.