-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[Github][CI] Stop running premerge checks on main #139358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Github][CI] Stop running premerge checks on main #139358
Conversation
Created using spr 1.3.4
This patch stops running the premerge checks on the main branch. This is based on some feedback in https://discourse.llvm.org/t/rfc-running-premerge-postcommit-through-github-actions/86124. We want to use buildbot for post commit testing. This should be covered in the mean time by the current pemerge-monolithic-* bots even though the configurations are not exactly the same. This also adds a bit of capacity back to the cluster (although might not in the end when we start running more substantial postcommit testing through buildbot). This is primarily in preparation for turning the new premerge system on as canonical. Without this, we run into warning fatigue issues as described in the RFC above. Pull Request: llvm#139358
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch stops running the premerge checks on the main branch. This is This is primarily in preparation for turning the new premerge system on Full diff: https://github.com/llvm/llvm-project/pull/139358.diff 1 Files Affected:
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 2ee1ecaf505c3..74ac80ba1b86f 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -16,7 +16,6 @@ on:
- closed
push:
branches:
- - 'main'
- 'release/**'
concurrency:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still plan to bring this back later or do you want to invest in buildbot for the foreseeable future?
(Your RFC didn't seem like a complete dead end to me necessarily)
If Github gives us more control over notifications, I think we can revisit. Otherwise, I think the plan is to focus on getting builtbot setup (properly) for postcommit testing. |
This patch stops running the premerge checks on the main branch. This is
based on some feedback in
https://discourse.llvm.org/t/rfc-running-premerge-postcommit-through-github-actions/86124.
We want to use buildbot for post commit testing. This should be covered
in the mean time by the current pemerge-monolithic-* bots even though
the configurations are not exactly the same. This also adds a bit of
capacity back to the cluster (although might not in the end when we
start running more substantial postcommit testing through buildbot).
This is primarily in preparation for turning the new premerge system on
as canonical. Without this, we run into warning fatigue issues as
described in the RFC above.