[HIP] Fix return type in __clang_hip_cmath.h #139697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Juan Manuel Martinez Caamaño (jmmartinez) ChangesBefore, some functions like I've stumbled upon this bug while trying to adapt Full diff: https://github.com/llvm/llvm-project/pull/139697.diff 1 Files Affected:
diff --git a/clang/lib/Headers/__clang_hip_cmath.h b/clang/lib/Headers/__clang_hip_cmath.h
index 7d982ad9af7ee..8039d0e12d7c9 100644
--- a/clang/lib/Headers/__clang_hip_cmath.h
+++ b/clang/lib/Headers/__clang_hip_cmath.h
@@ -464,12 +464,13 @@ class __promote : public __promote_imp<_A1, _A2, _A3> {};
#if __cplusplus >= 201103L
#define __HIP_OVERLOAD2(__retty, __fn) \
template <typename __T1, typename __T2> \
- __DEVICE__ __CONSTEXPR__ typename __hip_enable_if< \
- __hip::is_arithmetic<__T1>::value && __hip::is_arithmetic<__T2>::value, \
- typename __hip::__promote<__T1, __T2>::type>::type \
- __fn(__T1 __x, __T2 __y) { \
- typedef typename __hip::__promote<__T1, __T2>::type __result_type; \
- return __fn((__result_type)__x, (__result_type)__y); \
+ __DEVICE__ __CONSTEXPR__ \
+ typename __hip_enable_if<__hip::is_arithmetic<__T1>::value && \
+ __hip::is_arithmetic<__T2>::value, \
+ __retty>::type \
+ __fn(__T1 __x, __T2 __y) { \
+ typedef typename __hip::__promote<__T1, __T2>::type __arg_type; \
+ return __fn((__arg_type)__x, (__arg_type)__y); \
}
#else
#define __HIP_OVERLOAD2(__retty, __fn) \
|
|
Added tests and created a separate PR to commit the tests before the fix in #139891 |
jmmartinez
added a commit
that referenced
this pull request
May 15, 2025
Before, some functions like std::isgreater(double, doulbe) would return a double instead of a bool.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 15, 2025
…th.h (#139891) Tests related to llvm/llvm-project#139697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, some functions like
isgreater(float, double)would return adoubleinstead of abool.I've stumbled upon this bug while trying to adapt
External/CUDA/cmath.cuto HIP.