Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mlir][core] Add an MLIR "pattern catalog" generator #146228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j2kun merged 13 commits into from
Jul 17, 2025
Merged

[mlir][core] Add an MLIR "pattern catalog" generator #146228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7335db1
Add an MLIR "pattern catalog" generator.
j2kun Apr 28, 2025
85d6e9a
remove use of RTTI
j2kun Jun 29, 2025
0c86b84
remove mutex/file writes in favor of toolsubst+llvm::dbgs
j2kun Jun 30, 2025
5d4cfdd
add debug log marker for ease of filtering
j2kun Jun 30, 2025
182eafb
formatting
j2kun Jun 30, 2025
5fb5dea
Apply RAII
j2kun Jun 30, 2025
66a94cb
Remove need for post set-listener with RAII
j2kun Jun 30, 2025
79688e2
formatting
j2kun Jun 30, 2025
0915b0b
rename to PatternLoggingListener
j2kun Jun 30, 2025
a46f1d3
rename catalogingListener -> loggingListener
j2kun Jun 30, 2025
1aa1842
use LDBG macro for brevity
j2kun Jul 2, 2025
ed693d8
add lit test
j2kun Jul 5, 2025
0f07799
make test work with windows
j2kun Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove use of RTTI
  • Loading branch information
@j2kun
j2kun committed Jul 5, 2025
commit 85d6e9a6a06f82b51e91a8ba3d966729bd7bba23
4 changes: 1 addition & 3 deletions mlir/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@ endif()

#-------------------------------------------------------------------------------
# MLIR Pattern Catalog Generator Configuration
# Requires:
# RTTI to be enabled (set with -DLLVM_ENABLE_RTTI=ON)
#
# When enabled, causes all rewriter patterns to dump their type names and the
# names of affected operations, which can be used to build a search index
# mapping operations to patterns.
Expand All @@ -219,7 +218,6 @@ set(MLIR_ENABLE_CATALOG_GENERATOR 0 CACHE BOOL
if (MLIR_ENABLE_CATALOG_GENERATOR)
message(STATUS "Enabling MLIR pattern catalog generator")
add_definitions(-DMLIR_ENABLE_CATALOG_GENERATOR)
add_definitions(-DLLVM_ENABLE_RTTI)
endif()

set(CMAKE_INCLUDE_CURRENT_DIR ON)
Expand Down
7 changes: 3 additions & 4 deletions mlir/include/mlir/IR/PatternMatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,9 +476,8 @@ class RewriterBase : public OpBuilder {
};

struct CatalogingListener : public RewriterBase::ForwardingListener {
CatalogingListener(OpBuilder::Listener *listener,
const std::string &patternName, raw_ostream &os,
std::mutex &writeMutex)
CatalogingListener(OpBuilder::Listener *listener, StringRef patternName,
raw_ostream &os, std::mutex &writeMutex)
: RewriterBase::ForwardingListener(listener), patternName(patternName),
os(os), writeMutex(writeMutex) {}

Expand Down Expand Up @@ -544,7 +543,7 @@ class RewriterBase : public OpBuilder {
}

private:
const std::string &patternName;
StringRef patternName;
raw_ostream &os;
std::mutex &writeMutex;
};
Expand Down
16 changes: 1 addition & 15 deletions mlir/lib/Rewrite/PatternApplicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#ifdef MLIR_ENABLE_CATALOG_GENERATOR
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/raw_ostream.h"
#include <cxxabi.h>
#include <mutex>
#endif

Expand Down Expand Up @@ -232,22 +231,9 @@ LogicalResult PatternApplicator::matchAndRewrite(

#ifdef MLIR_ENABLE_CATALOG_GENERATOR
OpBuilder::Listener *oldListener = rewriter.getListener();
int status;
const char *mangledPatternName = typeid(*pattern).name();
char *demangled = abi::__cxa_demangle(mangledPatternName, nullptr,
nullptr, &status);
std::string demangledPatternName;
if (status == 0 && demangled) {
demangledPatternName = demangled;
free(demangled);
} else {
// Fallback in case demangling fails.
demangledPatternName = mangledPatternName;
}

RewriterBase::CatalogingListener *catalogingListener =
new RewriterBase::CatalogingListener(
oldListener, demangledPatternName, catalogOs,
oldListener, pattern->getDebugName(), catalogOs,
catalogWriteMutex);
rewriter.setListener(catalogingListener);
#endif
Expand Down