[Clang][Test] Add PS5 and WI cases to clang/test/Sema/dllexport.c#148818
Merged
bd1976bris merged 1 commit intollvm:mainfrom Jul 18, 2025
Merged
[Clang][Test] Add PS5 and WI cases to clang/test/Sema/dllexport.c#148818bd1976bris merged 1 commit intollvm:mainfrom
bd1976bris merged 1 commit intollvm:mainfrom
Conversation
Windows Itanium and PS5 are both Itanium C++ ABI variants which have the goal of semantic compatibility with Microsoft C++ code that uses dllimport/export. This patch adds Windows Itanium and PS5 triple testing to clang/test/Sema/dllexport.c. We have this testing in our downstream toolchain - for some reason it was not added upstream when the work for supporting dllimport/export was done.
Member
|
@llvm/pr-subscribers-clang Author: bd1976bris (bd1976bris) ChangesWindows Itanium and PS5 are both Itanium C++ ABI variants which have the goal of semantic compatibility with Microsoft C++ code that uses dllimport/export. This patch adds Windows Itanium and PS5 triple testing to clang/test/Sema/dllexport.c. We have this testing in our downstream toolchain - for some reason it was not added upstream when the work for supporting dllimport/export was done. Full diff: https://github.com/llvm/llvm-project/pull/148818.diff 1 Files Affected:
diff --git a/clang/test/Sema/dllexport.c b/clang/test/Sema/dllexport.c
index 3f911fb095c0f..5f6ff36e290e9 100644
--- a/clang/test/Sema/dllexport.c
+++ b/clang/test/Sema/dllexport.c
@@ -2,6 +2,10 @@
// RUN: %clang_cc1 -triple x86_64-win32 -fsyntax-only -fms-extensions -verify -std=c11 %s
// RUN: %clang_cc1 -triple i686-mingw32 -fsyntax-only -fms-extensions -verify -std=c11 %s
// RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions -verify -std=c99 %s
+// RUN: %clang_cc1 -triple i686-windows-itanium -fsyntax-only -fms-extensions -verify -std=c99 %s
+// RUN: %clang_cc1 -triple x86_64-windows-itanium -fsyntax-only -fms-extensions -verify -std=c11 %s
+// RUN: %clang_cc1 -triple x86_64-sie-ps5 -fsyntax-only -fms-extensions -verify -std=c99 %s
+// RUN: %clang_cc1 -triple x86_64-sie-ps5 -fsyntax-only -fms-extensions -verify -std=c11 %s
// Invalid usage.
__declspec(dllexport) typedef int typedef1;
|
compnerd
approved these changes
Jul 17, 2025
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Itanium and PS5 are both Itanium C++ ABI variants which have the goal of semantic compatibility with Microsoft C++ code that uses dllimport/export.
This patch adds Windows Itanium and PS5 triple testing to clang/test/Sema/dllexport.c. We have this testing in our downstream toolchain - for some reason it was not added upstream when the work for supporting dllimport/export was done.