[lldb-dap] Fix type req->arguments == "disconnect"#149446
Merged
Conversation
This typo was introduced in PR llvm#140331. This branch will never get executed. We also set the `disconnecting = true` in the `DAP::Disconnect()` so I am not sure if we need it in both places.
Member
|
@llvm/pr-subscribers-lldb Author: Wanyi (kusmour) ChangesThis typo was introduced in PR #140331. This branch will never get executed. We also set the Full diff: https://github.com/llvm/llvm-project/pull/149446.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp
index fd89f52595ec6..cbd3b14463e25 100644
--- a/lldb/tools/lldb-dap/DAP.cpp
+++ b/lldb/tools/lldb-dap/DAP.cpp
@@ -983,7 +983,7 @@ llvm::Error DAP::Loop() {
if (const protocol::Request *req =
std::get_if<protocol::Request>(&*next);
- req && req->arguments == "disconnect")
+ req && req->command == "disconnect")
disconnecting = true;
const std::optional<CancelArguments> cancel_args =
|
JDevlieghere
approved these changes
Jul 18, 2025
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 8, 2025
This typo was introduced in PR llvm#140331. This branch will never get executed. We also set the `disconnecting = true` in the `DAP::Disconnect()` so I am not sure if we need it in both places. (cherry picked from commit de453e8)
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Dec 17, 2025
This typo was introduced in PR llvm#140331. This branch will never get executed. We also set the `disconnecting = true` in the `DAP::Disconnect()` so I am not sure if we need it in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typo was introduced in PR #140331. This branch will never get executed. We also set the
disconnecting = truein theDAP::Disconnect()so I am not sure if we need it in both places.