[LLVM][MLIR] Move LSP server support library from MLIR into LLVM #157885
+2,413
−2,232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikic can I ask for a review? |
nikic
reviewed
Sep 11, 2025
| ) | ||
| target_link_libraries(LLVMSupportLSPTests | ||
| PRIVATE | ||
| LLVMSupportLSP) |
There was a problem hiding this comment.
Should also link as component.
| @@ -12,6 +12,9 @@ llvm_add_library(TableGenLspServerLib | |||
| ADDITIONAL_HEADER_DIRS | |||
| ${MLIR_MAIN_INCLUDE_DIR}/mlir/Tools/tblgen-lsp-server | |||
|
|
|||
| LINK_COMPONENTS | |||
| SupportLSP | |||
There was a problem hiding this comment.
I'd add this to LLVM_LINK_COMPONENTS above to avoid mixing two styles.
There was a problem hiding this comment.
Ah, sure, missed that
|
Yes, I checked that compiling with the same CMake settings as the dylib build linked all fine. |
nikic
approved these changes
Sep 11, 2025
|
Thanks for the approve, can you also merge this please? I don't have the permissions to do that. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/13305 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/30551 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/206/builds/6062 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/18938 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/12830 Here is the relevant piece of the build log for the reference |
|
Hopeful fix for buildbots: 299ba5d |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/21763 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/22951 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/21740 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/9702 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/21091 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/12498 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/24715 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/24855 Here is the relevant piece of the build log for the reference |
alanzhao1
pushed a commit
to alanzhao1/llvm-project
that referenced
this pull request
Sep 11, 2025
Reverts llvm#157691 Change was relanded in llvm#157885
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 11, 2025
Reverts llvm/llvm-project#157691 Change was relanded in llvm/llvm-project#157885
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds/19913 Here is the relevant piece of the build log for the reference |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Unfortunately, according to git bisect, this change is also responsible for the following test regression: Full logs (with CMake invocations, etc.): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second PR on this patch (first #155572), that fixes the linking problem for
flang-aarch64-dylibtest.The SupportLSP library was made a component library.
This PR moves the generic Language Server Protocol (LSP) server support code that was copied from clangd into MLIR, into the LLVM tree so it can be reused by multiple subprojects.
Centralizing the generic LSP support in LLVM lowers the barrier to building new LSP servers across the LLVM ecosystem and avoids each subproject maintaining its own copy.
The code originated in clangd and was copied into MLIR for its LSP server. MLIR had this code seperate to be reused by all of their LSP server. This PR relocates the MLIR copy into LLVM as a shared component into LLVM/Support. If this is not a suitable place, please suggest a better one.
A follow up to this move could be deduplication with the original clangd implementation and converge on a single shared LSP support library used by clangd, MLIR, and future servers.
What changes
and their namespace was changed from mlir to llvm
I ran clang-tidy --fix and clang-format on the whole moved files (last two commits), as they are basically new files and should hold up to the code style used by LLVM.
MLIR LSP servers where updated to include these files from their new location and account for the namespace change.
This PR is made as part of the LLVM IR LSP project (RFC)