Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Runtimes] Rework and remove default runtimes build #158156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Runtimes] Rework and remove default runtimes build #158156

wants to merge 2 commits into from
+103 −183

Conversation

jhuber6
Copy link
Contributor

@jhuber6 jhuber6 commented Sep 11, 2025 •
edited
Loading

Summary:
Currently the runtimes builds works by creating separate CMake projects
that build the respetive runtime. Right now we have a separate handling
for the 'default' target and manually specific runtimes via the
-DLLVM_RUNTIME_TARGETS option.

This patch changes the behavior to put all runtimes through the
LLVM_RUNTIME_TARGETS pipeline. The old "default" argument is now a
shorthand for LLVM_DEFAULT_TARGET_TRIPLE and corresponds to a sane
default.

In practical terms, this means the old runtimes-bins directory will
now be runtimes-x86_64-unknown-linux-gnu-bins for the majority of
users. We will not have check-<name> targets, but I have made
a top-level target that invokes all of the enabled targets check lines
to keep this backward compatible. So ninja check-cxx will still work.

There's likely some edge cases I missed here, but it seems to work in
the typical case for me. We'll see what CI thinks of this.

@jhuber6 jhuber6 added llvm Umbrella label for LLVM issues cmake Build system in general and CMake in particular labels Sep 11, 2025
@jhuber6
[Runtimes] Rework and remove default runtimes build
9e14f89 
Summary:
Currently the runtimes builds works by creating separate CMake projects
that build the respetive runtime. Right now we have a separate handling
for the 'default' target and manually specific runtimes via the
`-DLLVM_RUNTIME_TARGETS` option.

This patch changes the behavior to put all runtimes through the
`LLVM_RUNTIME_TARGETS` pipeline. The old `"default"` argument is now a
shorthand for `LLVM_DEFAULT_TARGET_TRIPLE` and corresponds to a sane
default.

In practical terms, this means the old `runtimes-bins` directory will
now be `runtimes-x86_64-unknown-linux-gnu-bins` for the majority of
users. We will not have `check-<name>-<triple>` targets, but I have made
a top-level target that invokes all of the enabled targets check lines
to keep this backward compatible.

There's likely some edge cases I missed here, but it seems to work in
the typical case for me. We'll see what CI thinks of this.
@jhuber6
Handle -DRUNTIMES_default_
2082d82
@mgorny
Copy link
Member

mgorny commented Sep 13, 2025

Oh, that's llvm/runtimes and not top-level runtimes, so I guess it won't affect Gentoo.

@jhuber6
Copy link
Contributor Author

jhuber6 commented Sep 13, 2025

Oh, that's llvm/runtimes and not top-level runtimes, so I guess it won't affect Gentoo.

Yes, ideally this change doesn't affect anyone that isn't depending on the name of directories in the build tree. Fundamentally I'm hoping to make our runtimes infrastructure more predictable by removing this weird disconnect we have between the generic and specific targets. More or less, this change is equivalent to the user putting -DRUNTIME_TARGETS=${LLVM_DEFAULT_TARGET_TRIPLE}. I want to keep the functionality of default because it's very important that things like cache files can target the user's default system.

I added the check targets to give an interface that looks the same as what we have now for the majority of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd Awaiting requested review from compnerd

@ldionne ldionne Awaiting requested review from ldionne

@Meinersbur Meinersbur Awaiting requested review from Meinersbur

@mgorny mgorny Awaiting requested review from mgorny

@mordante mordante Awaiting requested review from mordante

@nikic nikic Awaiting requested review from nikic

@petrhosek petrhosek Awaiting requested review from petrhosek

@philnik777 philnik777 Awaiting requested review from philnik777

Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular llvm Umbrella label for LLVM issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhuber6 @mgorny