Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reland "[compiler-rt][test] Use packaging.version.Version to compare glibc versions" (#158230)" #158236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

Reland "[compiler-rt][test] Use packaging.version.Version to compare glibc versions" (#158230)" #158236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df897a7
Reland "[compiler-rt][test] Use packaging.version.Version to compare …
DavidSpickett Sep 12, 2025
efa1a8b
fix exception handling
DavidSpickett Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions compiler-rt/test/lit.common.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,13 @@ def add_glibc_versions(ver_string):
if config.android:
return

from distutils.version import LooseVersion
from packaging.version import Version, InvalidVersion

try:
ver = Version(ver_string)
except InvalidVersion:
return

ver = LooseVersion(ver_string)
any_glibc = False
for required in [
"2.19",
Expand All @@ -727,7 +731,7 @@ def add_glibc_versions(ver_string):
"2.38",
"2.40",
]:
if ver >= LooseVersion(required):
if ver >= Version(required):
config.available_features.add("glibc-" + required)
any_glibc = True
if any_glibc:
Expand Down