Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

parabola94
Copy link
Contributor

LLVM has a mechanism to switch the default target: LLVM_TARGET_TRIPLE_ENV. For example, regression tests with lit use this CMake variable. It matters only when building LLVM, not the other projects. Therefore, if they are built standalone, the value of the CMake variable should be propagated. In fact, however, it is not.
This patch fixes it.

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Sep 12, 2025
LLVM has a mechanism to switch the default target: LLVM_TARGET_TRIPLE_ENV.
For example, regression tests with lit use this CMake variable.
It matters only when building LLVM, not the other projects.
Therefore, if they are built standalone, the value of the CMake variable should be propagated.
In fact, however, it is not.
This patch fixes it.
@parabola94 parabola94 force-pushed the propagate-llvm-target-triple-env branch from 2f2dbd1 to 6464910 Compare September 13, 2025 08:29
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parabola94 parabola94 enabled auto-merge (squash) September 15, 2025 23:02
@parabola94 parabola94 merged commit 7cdffde into llvm:main Sep 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants