reapply "[clang-tidy] support query based custom check" #159547
Conversation
This reverts commit a686695.
Co-authored-by: Baranov Victor <[email protected]>
…' into users/ccc/clang-tidy/query-check
…s/ccc/clang-tidy/query-check
Co-authored-by: Baranov Victor <[email protected]>
Co-authored-by: Baranov Victor <[email protected]>
|
@ingomueller-net could you kindly review this PR. I think I have fixed build issue but since I cannot reproduce it locally. I am not 100% sure it can work. Fix commit: 296eea3 |
There was a problem hiding this comment.
Sorry, spoke too soon. Building clang-tidy still has a lot of problems. The first one is the following but there are too many to copy them here.
ld.lld: error: undefined symbol: clang::ast_matchers::MatchFinder::addDynamicMatcher(clang::ast_matchers::internal::DynTypedMatcher const&, clang::ast_matchers::MatchFinder::MatchCallback*)
>>> referenced by QueryCheck.cpp:123 (/usr/local/google/home/ingomueller/git/llvm-project/clang-tools-extra/clang-tidy/custom/QueryCheck.cpp:123)
>>> tools/clang/tools/extra/clang-tidy/custom/CMakeFiles/obj.clangTidyCustomModule.dir/QueryCheck.cpp.o:(clang::tidy::custom::QueryCheck::registerMatchers(clang::ast_matchers::MatchFinder*))
Did you try to build with BUILD_SHARED_LIB?
|
I found how to reproduce it. Build failed happened in ubuntu with |
|
I think it works now. |
reapply #131804 and #159289
Fixed cmake link issue.