Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't omit null pointer checks with -fms-kernel #193800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eleviant wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Don't omit null pointer checks with -fms-kernel #193800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clang/lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1924,6 +1924,11 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args,
Opts.DIBugsReportFilePath = "";
}

if (LangOpts->Kernel &&
!Args.hasFlag(OPT_fdelete_null_pointer_checks,
OPT_fno_delete_null_pointer_checks, false))
Opts.NullPointerIsValid = true;

Opts.NewStructPathTBAA = !Args.hasArg(OPT_no_struct_path_tbaa) &&
Args.hasArg(OPT_new_struct_path_tbaa);
Opts.OptimizeSize = getOptimizationLevelSize(Args);
Expand Down
13 changes: 13 additions & 0 deletions clang/test/CodeGen/MSKernel/null-deref.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Check that null pointer checks are not omited in kernel mode compilations
// RUN: %clang_cc1 -fms-kernel -fms-extensions -triple x86_64-pc-windows-msvc -O2 %s -S -o - | FileCheck %s
Copy link
Copy Markdown
Contributor

@dpaoliello dpaoliello Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check in the IR that the function has the correct attribute applied - otherwise this test requires the x86 target.

// CHECK: # %bb.0
// CHECK-NEXT: testq %rcx, %rcx

struct Obj { int value; int extra; };

int process(struct Obj* p) {
int v = p->value;
if (!p)
return -1;
return v + p->extra;
}