[libcxx][Github] Add generic-llvm-libc config to CI#193822
Open
boomanaiden154 wants to merge 9 commits intollvm:mainfrom
Open
[libcxx][Github] Add generic-llvm-libc config to CI#193822boomanaiden154 wants to merge 9 commits intollvm:mainfrom
boomanaiden154 wants to merge 9 commits intollvm:mainfrom
Conversation
Add the generic-llvm-libc config for CI so that we can ensure we do not regress the config and easily test changes as we do more work. Only run libcxx/libxxabi tests for now as libunwind fails to build due to a missing dl_iterate_phdr implementation. It technically passes when we enable the stub implementation, but we should have a reasonable implementation before actually enabling.
Member
|
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesAdd the generic-llvm-libc config for CI so that we can ensure we do not regress the config and easily test changes as we do more work. Only run libcxx/libxxabi tests for now as libunwind fails to build due to a missing dl_iterate_phdr implementation. It technically passes when we enable the stub implementation, but we should have a reasonable implementation before actually enabling. Full diff: https://github.com/llvm/llvm-project/pull/193822.diff 2 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 83f8f89ac5fe2..c5421addefa30 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -144,6 +144,7 @@ jobs:
'generic-hardening-mode-extensive-observe-semantic',
'generic-hardening-mode-fast',
'generic-hardening-mode-fast-with-abi-breaks',
+ 'generic-llvm-libc',
'generic-merged',
'generic-modules-cxx17-lsv',
'generic-no-exceptions',
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index cbb0846dfc7d1..44507f05011fa 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -466,7 +466,19 @@ generic-llvm-libc)
# Ensure we have the builtins archive built as we pass it in explicitly in
# the test config.
ninja -vC "${BUILD_DIR}" libclang_rt.builtins-x86_64.a
- check-runtimes
+
+ # Manually run only libcxx/libcxxabi tests as we currently cannot build
+ # libunwind due to a missing dl_iterate_phdr implementation.
+ # TODO(boomanaiden154): Remove this once we can build libunwind and pass
+ # the tests.
+ step "Building libc++ test dependencies"
+ ninja -vC "${BUILD_DIR}" cxx-test-depends
+
+ step "Running the libc++ tests"
+ ninja -vC "${BUILD_DIR}" check-cxx
+
+ step "Running the libc++abi tests"
+ ninja -vC "${BUILD_DIR}" check-cxxabi
;;
#
# Module builds
|
philnik777
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the generic-llvm-libc config for CI so that we can ensure we do not regress the config and easily test changes as we do more work.
Only run libcxx/libxxabi tests for now as libunwind fails to build due to a missing dl_iterate_phdr implementation. It technically passes when we enable the stub implementation, but we should have a reasonable implementation before actually enabling.