Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[libc++] Implement views::join_with#65536

Merged
huixie90 merged 56 commits intollvm:mainfrom
JMazurkiewicz:libcxx/ranges/join_with
Jun 21, 2025
Merged

[libc++] Implement views::join_with#65536
huixie90 merged 56 commits intollvm:mainfrom
JMazurkiewicz:libcxx/ranges/join_with

Conversation

@JMazurkiewicz
Copy link
Copy Markdown
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 6, 2023

@github-actions github-actions Bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 6, 2023
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 5 times, most recently from 3259db4 to 0481670 Compare September 8, 2023 00:07
Comment thread libcxx/docs/Status/Cxx23Papers.csv Outdated
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from 0481670 to f113229 Compare September 8, 2023 15:11
@ldionne ldionne assigned var-const and huixie90 and unassigned var-const Sep 13, 2023
@ldionne ldionne requested a review from huixie90 September 15, 2023 20:55
@ldionne
Copy link
Copy Markdown
Member

ldionne commented Sep 15, 2023

@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft.

@philnik777 philnik777 added the ranges Issues related to `<ranges>` label Oct 6, 2023
ldionne pushed a commit that referenced this pull request Oct 24, 2023
This patch adds a mention that the following papers are in progress:

* P2770R0: #66033
* P2441R2 and P2711R1: #65536
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from f113229 to 1835f68 Compare February 2, 2024 23:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 4, 2024 14:58
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 4, 2024 14:58
@H-G-Hristov
Copy link
Copy Markdown
Contributor

H-G-Hristov commented May 10, 2024

I guess with constexpr variant this cool feature can be finalized now :)

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from a84985a to fcdf64a Compare May 14, 2024 14:38
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from 54a741c to a9a1031 Compare May 22, 2024 23:17
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from a9a1031 to 9406093 Compare June 5, 2024 09:49
@JMazurkiewicz
Copy link
Copy Markdown
Contributor Author

Ping @huixie90

Copy link
Copy Markdown
Member

@huixie90 huixie90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits. Thanks very much for the patch!

Comment thread libcxx/docs/ReleaseNotes/21.rst
Comment thread libcxx/include/__ranges/join_with_view.h Outdated
Comment thread libcxx/include/__ranges/join_with_view.h Outdated
Comment thread libcxx/include/__ranges/join_with_view.h Outdated
@ldionne ldionne added pending-ci Merging the PR is only pending completion of CI and removed pending-ci Merging the PR is only pending completion of CI labels May 12, 2025
@ldionne
Copy link
Copy Markdown
Member

ldionne commented May 12, 2025

Sorry for the churn about the pending-ci tag -- I missed that there were still a few comments to resolve before merging.

@JMazurkiewicz
Copy link
Copy Markdown
Contributor Author

Thank you @huixie90 for your review. I've pushed commits addressing your latest comments (95ea7bc, 8ab29fb, 7198928), and changing three more things:

  • 6cb18ac - This commit fixes problem with friendship (similar to this one) in the test suite.
  • 37525db - This commit fixes truncation warnings when testing MSVC standard library (so it's easier for them to update their llvm submodule).
  • de46d63 - LWG-4074 removed compatible-joinable-ranges, this commit updates synopsis.

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch from e08bf0c to fa9e257 Compare June 11, 2025 10:51
Copy link
Copy Markdown
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failures are probably unrelated.

@huixie90
Copy link
Copy Markdown
Member

Merging this as comments are addressed. CI is green except for msan, which is an existing issue on main and unrelated to this patch

@huixie90 huixie90 merged commit 1bb2328 into llvm:main Jun 21, 2025
155 of 181 checks passed
@JMazurkiewicz JMazurkiewicz deleted the libcxx/ranges/join_with branch June 21, 2025 14:04
androm3da added a commit to androm3da/llvm-project that referenced this pull request Feb 2, 2026
When a packet containing extended immediates and new-value compare-jump
instructions with fixups was followed by a .p2align directive, we
would incorrectly add nops to the packet. After reshuffling, the fixup
offsets would become invalid, causing corrupted encodings.

Fixes round-trip assembly for patterns like:

    {
      r18 = #llvm#65536
      if (!cmp.gtu(r1,r18.new)) jump:t .L1
    }
    .p2align 4
androm3da added a commit that referenced this pull request Feb 9, 2026
…179168)

When a packet containing extended immediates and new-value compare-jump
instructions with fixups was followed by a .p2align directive, we would
incorrectly add nops to the packet. After reshuffling, the fixup offsets
would become invalid, causing corrupted encodings.

Fixes round-trip assembly for patterns like:

    {
      r18 = ##65536
      if (!cmp.gtu(r1,r18.new)) jump:t .L1
    }
    .p2align 4
c-rhodes pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 18, 2026
…lvm#179168)

When a packet containing extended immediates and new-value compare-jump
instructions with fixups was followed by a .p2align directive, we would
incorrectly add nops to the packet. After reshuffling, the fixup offsets
would become invalid, causing corrupted encodings.

Fixes round-trip assembly for patterns like:

    {
      r18 = #llvm#65536
      if (!cmp.gtu(r1,r18.new)) jump:t .L1
    }
    .p2align 4

(cherry picked from commit 87d73f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. ranges Issues related to `<ranges>`

Projects

None yet

9 participants