Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[libc++][ranges] implement std::ranges::zip_transform_view #79605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huixie90 merged 27 commits into from
Jul 20, 2025
+3,525 −77
Merged

[libc++][ranges] implement std::ranges::zip_transform_view #79605

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7de6bb5
[libc++][ranges] implement `std::ranges::zip_transform_view`
huixie90 Jan 26, 2024
db14a59
add tests
huixie90 Jan 29, 2024
080c28f
rebase
huixie90 Jul 6, 2025
2c6e763
complete some lwg issues
huixie90 Jul 6, 2025
1ef4003
ci
huixie90 Jul 6, 2025
5861f2c
format
huixie90 Jul 6, 2025
1911bbc
module
huixie90 Jul 6, 2025
0049ed5
lint
huixie90 Jul 6, 2025
5b6f2c0
ci
huixie90 Jul 6, 2025
36b58ed
review
huixie90 Jul 6, 2025
0de1e4d
ci
huixie90 Jul 6, 2025
9a5c4ee
LWG
huixie90 Jul 6, 2025
eb62d38
remove non ascii
huixie90 Jul 6, 2025
d22c37a
ci
huixie90 Jul 6, 2025
6271251
Update libcxx/docs/Status/Cxx23Issues.csv
ldionne Jul 11, 2025
83f7e91
Update libcxx/test/std/ranges/range.adaptors/range.zip.transform/ctad…
huixie90 Jul 12, 2025
bacf9ec
Update libcxx/test/std/ranges/range.adaptors/range.zip.transform/iter…
huixie90 Jul 12, 2025
a7a687f
review
huixie90 Jul 13, 2025
f8b8be4
release note
huixie90 Jul 13, 2025
097957d
types.h
huixie90 Jul 13, 2025
afa77fc
review
huixie90 Jul 18, 2025
d001885
Update libcxx/docs/Status/Cxx23Issues.csv
huixie90 Jul 19, 2025
cd1ad54
Update libcxx/docs/Status/Cxx23Issues.csv
huixie90 Jul 19, 2025
f1b2c42
Update libcxx/test/std/ranges/range.adaptors/range.zip.transform/types.h
huixie90 Jul 19, 2025
dfe80fd
format
huixie90 Jul 19, 2025
908fb3f
review
huixie90 Jul 19, 2025
ef55fe6
CI
huixie90 Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci
  • Loading branch information
@huixie90
huixie90 committed Jul 19, 2025
commit 5b6f2c09e8a3e6f00756bd1ad51cb6ae50d811e7
16 changes: 10 additions & 6 deletions libcxx/include/__ranges/zip_transform_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
# pragma GCC system_header
#endif

_LIBCPP_PUSH_MACROS
#include <__undef_macros>
_LIBCPP_BEGIN_NAMESPACE_STD

#if _LIBCPP_STD_VER >= 23
Expand All @@ -59,11 +61,11 @@ class zip_transform_view : public view_interface<zip_transform_view<_Fn, _Views.
_LIBCPP_NO_UNIQUE_ADDRESS zip_view<_Views...> __zip_;
_LIBCPP_NO_UNIQUE_ADDRESS __movable_box<_Fn> __fun_;

using _InnerView = zip_view<_Views...>;
using _InnerView _LIBCPP_NODEBUG = zip_view<_Views...>;
template <bool _Const>
using __ziperator = iterator_t<__maybe_const<_Const, _InnerView>>;
using __ziperator _LIBCPP_NODEBUG = iterator_t<__maybe_const<_Const, _InnerView>>;
template <bool _Const>
using __zentinel = sentinel_t<__maybe_const<_Const, _InnerView>>;
using __zentinel _LIBCPP_NODEBUG = sentinel_t<__maybe_const<_Const, _InnerView>>;

template <bool>
class __iterator;
Expand Down Expand Up @@ -130,7 +132,7 @@ template <bool _Const, class _Fn, class... _Views>
struct __zip_transform_iterator_category_base<_Const, _Fn, _Views...> {
private:
template <class _View>
using __tag = typename iterator_traits<iterator_t<__maybe_const<_Const, _View>>>::iterator_category;
using __tag _LIBCPP_NODEBUG = typename iterator_traits<iterator_t<__maybe_const<_Const, _View>>>::iterator_category;

static consteval auto __get_iterator_category() {
if constexpr (!is_reference_v<invoke_result_t<__maybe_const<_Const, _Fn>&,
Expand Down Expand Up @@ -158,8 +160,8 @@ template <move_constructible _Fn, input_range... _Views>
template <bool _Const>
class zip_transform_view<_Fn, _Views...>::__iterator
: public __zip_transform_iterator_category_base<_Const, _Fn, _Views...> {
using _Parent = __maybe_const<_Const, zip_transform_view>;
using _Base = __maybe_const<_Const, _InnerView>;
using _Parent _LIBCPP_NODEBUG = __maybe_const<_Const, zip_transform_view>;
using _Base _LIBCPP_NODEBUG = __maybe_const<_Const, _InnerView>;

friend zip_transform_view<_Fn, _Views...>;

Expand Down Expand Up @@ -355,4 +357,6 @@ inline constexpr auto zip_transform = __zip_transform::__fn{};

_LIBCPP_END_NAMESPACE_STD

_LIBCPP_POP_MACROS

#endif // _LIBCPP___RANGES_ZIP_TRANSFORM_VIEW_H
8 changes: 4 additions & 4 deletions libcxx/test/std/ranges/range.adaptors/range.zip.transform/iterator/compare.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ constexpr bool test() {
int buffer1[1] = {1};
int buffer2[2] = {1, 2};
std::ranges::zip_transform_view v{MakeTuple{}, ForwardSizedView(buffer1), ForwardSizedView(buffer2)};
using View = decltype(v);
static_assert(std::ranges::common_range<View>);
static_assert(!std::ranges::bidirectional_range<View>);
using ZTV = decltype(v);
static_assert(std::ranges::common_range<ZTV>);
static_assert(!std::ranges::bidirectional_range<ZTV>);

auto it1 = v.begin();
auto it2 = v.end();
Expand Down Expand Up @@ -154,7 +154,7 @@ constexpr bool test() {

int main(int, char**) {
test();
//static_assert(test());
static_assert(test());

return 0;
}