Thanks to visit codestin.com
Credit goes to github.com

[llvm] Add option to emit `callgraph` section #87574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Prabhuk wants to merge 28 commits into users/Prabhuk/sprmain.callsiteinfocallgraphsection-extend-callsiteinfo-with-typeid from users/Prabhuk/sprcallsiteinfocallgraphsection-extend-callsiteinfo-with-typeid

Contributor

Prabhuk commented Apr 3, 2024 •

edited

Loading

Introducing EnableCallGraphSection target option. The cl::opt flag to
enable this option is --call-graph-section.

Adding CalleeTypeIds field to CallSiteInfo to tracking callee type ids.
Read the calle type ids in and out by the MIR parser/printer.

CalleeTypeIds is only set for callSites.CalleeTypeIds fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end.


          [𝘀𝗽𝗿] initial version

0ca57bd

Created using spr 1.3.6-beta.1

Prabhuk pushed a commit to Prabhuk/llvm-project that referenced this pull request


          [CallSiteInfo][CallGraphSection] Extend CallSiteInfo with TypeId

2b6eec5

Add TypeId field to CallSiteInfo for tracking callee type id. Read the type
id in and out by the MIR parser/printer.

With this patch, TypeId is only set from callSites.typeId fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end,
and they will be read and set while lowering in the LLVM middle-end.

Original RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-June/151044.html
Updated RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-July/151739.html

Reviewed By:
morehouse

Differential Revision: https://reviews.llvm.org/D107110?id=362890

Pull Request: llvm#87574

necipfazil added 7 commits

April 24, 2024 11:16


          Rebased on top of main

b9e7dc5

Created using spr 1.3.6-beta.1


          dyn_cast to isa

683d7c3

Created using spr 1.3.6-beta.1


          Addressed review comments except for the verifier check. Rebased on u…

661af56

…pstream main.

Created using spr 1.3.6-beta.1


          Rebase patchset

ae8f56a

Created using spr 1.3.6-beta.1


          Update inline comment as suggested.

d573bf0

Created using spr 1.3.6-beta.1


          Rebase on top of upstream main.

26a149b

Created using spr 1.3.6-beta.1


          Break clang and llvm parts into separate commits.

807cb0a

Created using spr 1.3.6-beta.1

Prabhuk requested review from ilovepi and arsenm

November 20, 2024 22:11


          Address review comments. Break llvm and clang patches.

3ab92c5

Created using spr 1.3.6-beta.1

Prabhuk changed the title ~~[CallSiteInfo][CallGraphSection] Extend CallSiteInfo with TypeId~~ [llvm] Extend CallSiteInfo with TypeId

ilovepi reviewed

View reviewed changes

llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir Outdated Show resolved Hide resolved

arsenm reviewed

View reviewed changes

llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir Outdated Show resolved Hide resolved

llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir Outdated Show resolved Hide resolved

necipfazil added 2 commits

February 2, 2025 00:58


          Simplify MIR test.

1d7ee61

Created using spr 1.3.6-beta.1


          Rebase on top of main.

1cf40e1

Created using spr 1.3.6-beta.1

Prabhuk mentioned this pull request

[llvm] Add option to emit call graph section #87572

Closed


          Rename OB_type to OB_callee_type.

39017d7

Created using spr 1.3.6-beta.1

Contributor

ilovepi commented Feb 6, 2025

I think we could probably do w/ a few more test cases.

Some direct calls (e.g. foo->bar, bar->fizz, bar->buzz)
the indirect callee is ambiguous (you could do this with control flow, or via parameter w/o much difference).
the type of the callee matches another function, but the callee is known (simplest case would be two void functions).

There may be other cases we also want to check, but these three seem like a good start. I imagine they could be useful as you flesh out more features too.


          Squash callgraph option change with MIR changes.

da97117

Created using spr 1.3.6-beta.1

Prabhuk changed the title ~~[llvm] Extend CallSiteInfo with TypeId~~ [llvm] Add option to emit callgraph section


          Rebase on top of main

6883cbd

Created using spr 1.3.6-beta.1

Prabhuk added a commit to Prabhuk/llvm-project that referenced this pull request


          [llvm] Add option to emit callgraph section

919f0cd

Introducing `EnableCallGraphSection` target option. The cl::opt flag to
enable this option is `--call-graph-section`.

Adding TypeId field to CallSiteInfo for tracking callee type id. Read the
type id in and out by the MIR parser/printer.

TypeId is only set for callSites.typeId fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end,
and they will be read and set while lowering in the LLVM middle-end.

Pull Request: llvm#87574

Prabhuk added 2 commits

March 13, 2025 01:03


          Add requested tests part 1.

86e2c9d

Created using spr 1.3.6-beta.1


          Update comments in tests.

941dde5

Created using spr 1.3.6-beta.1

Contributor Author

Prabhuk commented Mar 13, 2025

I think we could probably do w/ a few more test cases.

Some direct calls (e.g. foo->bar, bar->fizz, bar->buzz)

the indirect callee is ambiguous (you could do this with control flow, or via parameter w/o much difference).

the type of the callee matches another function, but the callee is known (simplest case would be two void functions).

There may be other cases we also want to check, but these three seem like a good start. I imagine they could be useful as you flesh out more features too.

I've added new tests for 1 & 2. I don't understand the purpose of the third suggestion.

Prabhuk requested a review from ilovepi

March 13, 2025 01:24

arsenm reviewed

View reviewed changes

llvm/test/CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir Outdated Show resolved Hide resolved

llvm/test/CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir Outdated Show resolved Hide resolved


          Clean up test files.

431fafc

Created using spr 1.3.6-beta.1

arsenm reviewed

View reviewed changes

llvm/lib/CodeGen/MIRParser/MIRParser.cpp Outdated Show resolved Hide resolved

llvm/lib/CodeGen/MIRParser/MIRParser.cpp Outdated Show resolved Hide resolved

llvm/lib/CodeGen/MIRParser/MIRParser.cpp Outdated Show resolved Hide resolved

llvm/test/CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir Outdated Show resolved Hide resolved

llvm/test/CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir Show resolved Hide resolved

ilovepi reviewed

View reviewed changes

llvm/include/llvm/CodeGen/MachineFunction.h Outdated Show resolved Hide resolved

llvm/lib/CodeGen/MIRPrinter.cpp Outdated Show resolved Hide resolved

llvm/test/CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir Outdated Show resolved Hide resolved


          Address code refactoring and test cleanup comments.

dc1b364

Created using spr 1.3.6-beta.1

Prabhuk added a commit to Prabhuk/llvm-project that referenced this pull request


          [llvm] Add option to emit callgraph section

46fd098

Introducing `EnableCallGraphSection` target option. The cl::opt flag to
enable this option is `--call-graph-section`.

Adding TypeId field to CallSiteInfo for tracking callee type id. Read the
type id in and out by the MIR parser/printer.

TypeId is only set for callSites.typeId fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end,
and they will be read and set while lowering in the LLVM middle-end.

Pull Request: llvm#87574


          Use list of CalleeTypeIds.

53b24d9

Created using spr 1.3.6-beta.1

Prabhuk added a commit to Prabhuk/llvm-project that referenced this pull request


          [llvm] Add option to emit callgraph section

edb60db

Introducing `EnableCallGraphSection` target option. The cl::opt flag to
enable this option is `--call-graph-section`.

Adding CalleeTypeIds field to CallSiteInfo to tracking callee type ids.
Read the calle type ids in and out by the MIR parser/printer.

CalleeTypeIds is only set for callSites.CalleeTypeIds fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end.

Pull Request: llvm#87574

Prabhuk added 4 commits

April 23, 2025 01:02


          Handle instcombine usecase for callee_type metadata.

a7409ab

Created using spr 1.3.6-beta.1


          Rebase on parent change.

8e67a0e

Created using spr 1.3.6-beta.1


          Address review comments.

e33f18b

Created using spr 1.3.6-beta.1


          Address review comments.

d4b6ae0

Created using spr 1.3.6-beta.1

ilovepi reviewed

View reviewed changes

llvm/lib/CodeGen/MIRPrinter.cpp Outdated Show resolved Hide resolved

Prabhuk added 4 commits

April 24, 2025 20:39


          Fix the test file formatting for calleeTypeIds.

9f94841

Created using spr 1.3.6-beta.1


          Destructuring.

64fcf91

Created using spr 1.3.6-beta.1


          Rebase on parent.

a703c75

Created using spr 1.3.6-beta.1


          Rebase on parent.

1a104c9

Created using spr 1.3.6-beta.1

Prabhuk force-pushed the users/Prabhuk/sprcallsiteinfocallgraphsection-extend-callsiteinfo-with-typeid branch from a703c75 to 1a104c9 Compare

May 1, 2025 20:48


          Rebase on parent.

b224d07

Created using spr 1.3.6-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet