Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Fortran/gfortran] Sync gfortran tests with upstream #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

[Fortran/gfortran] Sync gfortran tests with upstream #241

merged 3 commits into from
May 14, 2025

Conversation

tarunprabhu
Copy link
Contributor

@tarunprabhu tarunprabhu commented May 6, 2025 •
edited
Loading

These are synced with c182f4d14d65b3e012.

Any new tests that fail have been added to the appropriate deny lists. The reasons for these failures have not been thoroughly investigated though, so some recategorization may be necessary.

Some bugs in the build system for the tests was uncovered in the process and fixed.

Notes for reviewers: Only the following files need to be reviewed:

The tests.cmake files are generated by the update-test-config script. The source code files and .exp files are exactly the same as those upstream. None of these files need to be reviewed.

I have solicited reviews from a larger number of reviewers so the test suite can be tested on a wider range of platforms.

@tarunprabhu tarunprabhu marked this pull request as ready for review May 7, 2025 00:15
@tblah
Copy link
Contributor

tblah commented May 7, 2025

Fortran/gfortran/regression/pr117797.f90 fails for me at -O0 (STOP 2) but passes at -O1 and above.

@tarunprabhu
Copy link
Contributor Author

Thanks Tom. The test failed for me when I switched to a Debug build of the test suite on X86 as well. It has been disabled.

@ylzsx
Copy link
Contributor

ylzsx commented May 8, 2025

Thanks. The same test pr117797.f90 on a LoongArch 3A5000 machine also fails at -O0 (Fortran STOP: code 2) but passes at -O1 and above. However, when -flto=auto is enabled, the error reappears.

tblah
tblah approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all passes for me on aarch64

luporl
luporl approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the gfortran tests. No failures on my AArch64 machine.

ylzsx
ylzsx approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@ylzsx ylzsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all passes for me on loongarch64.

@kkwli
Copy link
Contributor

kkwli commented May 12, 2025 •
edited
Loading

Found the following failures with powerpc64le-unknown-linux-gnu.

test-suite :: Fortran/gfortran/regression/goacc/gfortran-regression-compile-regression__goacc__routine-8_f90.test
test-suite :: Fortran/gfortran/regression/goacc/gfortran-regression-compile-regression__goacc__routine-intrinsic-2_f.test

$ ~/llvm-install/bin/flang -fopenacc routine-8.f90 -c
$ echo $?
0

The same is for routine-intrinsic.2.f that the compiler does not issue any expected messages.

@tarunprabhu tarunprabhu force-pushed the update-gfortran-tests branch from 823df22 to ca1315d Compare May 13, 2025 14:50
@tarunprabhu
Copy link
Contributor Author

Thanks for taking a look, Kelvin. I see those tests failing for me too. Perhaps this is the result of a change in flang since last week.

jeanPerier
jeanPerier approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @tarunprabhu!

Works for me on X86-64 (ubuntu 22.04)

Testing Time: 37.63s

Total Discovered Tests: 6783
  Passed: 6783 (100.00%)

@tarunprabhu
Copy link
Contributor Author

I have filed an issue for the inconsistent behavior of 117797.f90.

AlexisPerry
AlexisPerry approved these changes May 13, 2025
View reviewed changes
Copy link

@AlexisPerry AlexisPerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for my configuration (amd-rome node)

Testing Time: 1866.40s

Total Discovered Tests: 6782
  Passed: 6782 (100.00%)

@kkwli
Copy link
Contributor

kkwli commented May 13, 2025

Thanks for taking a look, Kelvin. I see those tests failing for me too. Perhaps this is the result of a change in flang since last week.

@tarunprabhu It could be 4d9479.

@kkwli kkwli mentioned this pull request May 13, 2025
Merged
@tarunprabhu
[Fortran/gfortran] Sync gfortran tests with upstream
918b388 
These are synced with c182f4d14d65b3e012.

Any new tests that fail have been added to the appropriate deny lists. The
reasons for these failures have not been thoroughly investigated though, so
some recategorization may be necessary.

Some bugs in the build system for the tests was uncovered in the process and
fixed.
@tarunprabhu
Fix typos. Disable test that fails at -O0 but passes at higher optimi…
d6670ca 
…zation levels
@tarunprabhu
Disable two more failing tests - possibly the result of a recent chan…
38507f2 
…ge in flang
@tarunprabhu tarunprabhu force-pushed the update-gfortran-tests branch from ca1315d to 38507f2 Compare May 14, 2025 15:11
@tarunprabhu
Copy link
Contributor Author

Thanks @tblah, @ylzsx, @luporl, @kkwli, @jeanPerier and @AlexisPerry for testing this.

@tarunprabhu tarunprabhu merged commit 39bdfec into llvm:main May 14, 2025
1 check passed
@tarunprabhu tarunprabhu deleted the update-gfortran-tests branch May 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblah tblah tblah approved these changes

@kkwli kkwli kkwli approved these changes

@jeanPerier jeanPerier jeanPerier approved these changes

@AlexisPerry AlexisPerry AlexisPerry approved these changes

@luporl luporl luporl approved these changes

@ylzsx ylzsx ylzsx approved these changes

@kiranchandramohan kiranchandramohan Awaiting requested review from kiranchandramohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tarunprabhu @tblah @ylzsx @kkwli @jeanPerier @AlexisPerry @luporl