Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp #250

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
480e984
gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp
at055612 Mar 6, 2025
46f8d08
gh-249 Remove non-J8 features, use indent size 2
at055612 Mar 6, 2025
f92012e
gh-249 Fix indents
at055612 Mar 6, 2025
e1756d6
gh-249 Tidy code and refactor RangeComparator impls
at055612 Mar 6, 2025
9509f6b
gh-249 Remove commented code
at055612 Mar 6, 2025
67e2df1
gh-249 Add CursorIterableIntegerKeyTest
at055612 Mar 7, 2025
620a89f
gh-249 Remove MaskedFlag.isPropagatedToLmdb, add DbiBuilder WIP
at055612 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-249 Remove commented code
  • Loading branch information
@at055612
at055612 committed Mar 6, 2025
commit 9509f6bea115c7839e14881e4ecb4459211820d4
56 changes: 0 additions & 56 deletions src/main/java/org/lmdbjava/CursorIterable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
*/
public final class CursorIterable<T> implements Iterable<CursorIterable.KeyVal<T>>, AutoCloseable {

// private final Comparator<T> comparator;
private final RangeComparator rangeComparator;
private final Cursor<T> cursor;
private final KeyVal<T> entry;
Expand All @@ -69,68 +68,13 @@
}
}

// static <T> RangeComparator createJavaRangeComparator(
// final KeyRange<T> range,
// final Comparator<T> comparator,
// final Supplier<T> currentKeySupplier) {
// final T start = range.getStart();
// final T stop = range.getStop();
// return new RangeComparator() {
// @Override
// public int compareToStartKey() {
// return comparator.compare(currentKeySupplier.get(), start);
// }
//
// @Override
// public int compareToStopKey() {
// return comparator.compare(currentKeySupplier.get(), stop);
// }
// };
// }

// /**
// * Calls down to mdb_cmp to make use of the comparator that LMDB uses for insertion order.
// *
// * @param txnPointer The pointer to the transaction.
// * @param dbiPointer The pointer to the Dbi so LMDB can use the comparator of the Dbi
// * @param proxy
// */
// private RangeComparator createLmdbDbiComparator(final Pointer txnPointer,
// final Pointer dbiPointer,
// final Pointer cursorKeyPointer,
// final KeyRange<T> range,
// final BufferProxy<T> proxy) {
// Objects.requireNonNull(txnPointer);
// Objects.requireNonNull(dbiPointer);
// Objects.requireNonNull(range);
// Objects.requireNonNull(cursor);
// // Allocate buffers for use with the start/stop keys if required.
// // Saves us copying bytes on each comparison
// final Key<T> startKey = createKey(range.getStart(), proxy);
// final Key<T> stopKey = createKey(range.getStop(), proxy);
//
// return new RangeComparator() {
// @Override
// public int compareToStartKey() {
// return LIB.mdb_cmp(txnPointer, dbiPointer, cursor.keyVal().pointerKey(),
// startKey.pointer());
// }
//
// @Override
// public int compareToStopKey() {
// return LIB.mdb_cmp(txnPointer, dbiPointer, cursor.keyVal().pointerKey(),
// stopKey.pointer());
// }
// };
// }

@Override
public void close() {
cursor.close();
try {
rangeComparator.close();
} catch (Exception e) {
throw new RuntimeException(e);

Check warning on line 77 in src/main/java/org/lmdbjava/CursorIterable.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/lmdbjava/CursorIterable.java#L76-L77 

Added lines #L76 - L77 were not covered by tests
}
}

Expand Down
Loading